FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: add cache to nearest parent package json by IlyasShabi · Pull Request #59086 · nodejs/node · GitHub

  1. nodejs
  2. node

Repository navigation

src: add cache to nearest parent package json #59086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jul 21, 2025
Conversation 13 Commits 1 Checks 0 Files changed
Merged

src: add cache to nearest parent package json #59086

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .js  (1) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
src: add cache to nearest parent package json
  • Loading branch information
IlyasShabi committed Jul 21, 2025
commit 0a098d202fbb11341b2b1e95e3664d943f8698a0
13 changes: 12 additions & 1 deletion lib/internal/modules/package_json_reader.js
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const {
JSONParse,
ObjectDefineProperty,
RegExpPrototypeExec,
SafeMap,
StringPrototypeIndexOf,
StringPrototypeSlice,
} = primordials;
Expand All @@ -28,6 +29,8 @@ const path = require('path');
const { validateString } = require('internal/validators');
const internalFsBinding = internalBinding('fs');

const nearestParentPackageJSONCache = new SafeMap();

/**
* @typedef {import('typings/internalBinding/modules').DeserializedPackageConfig} DeserializedPackageConfig
* @typedef {import('typings/internalBinding/modules').PackageConfig} PackageConfig
Expand Down Expand Up @@ -131,13 +134,21 @@ function read(jsonPath, { base, specifier, isESM } = kEmptyObject) {
* @returns {undefined | DeserializedPackageConfig}
*/
function getNearestParentPackageJSON(checkPath) {
if (nearestParentPackageJSONCache.has(checkPath)) {
return nearestParentPackageJSONCache.get(checkPath);
}

const result = modulesBinding.getNearestParentPackageJSON(checkPath);

if (result === undefined) {
nearestParentPackageJSONCache.set(checkPath, undefined);
return undefined;
}

return deserializePackageJSON(checkPath, result);
const packageConfig = deserializePackageJSON(checkPath, result);
nearestParentPackageJSONCache.set(checkPath, packageConfig);

return packageConfig;
}

/**
Expand Down
Back | FazBrowse Home | New Git URL