test: fix flaky test-repl - #5914
Merged
mscdex merged 1 commit intoMar 30, 2016
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
What about just removing the timeout? |
Sorry, something went wrong.
mscdex
force-pushed
the
test-flaky-repl
branch
2 times, most recently
from
4b84e7a to
db35809
Compare
March 26, 2016 15:20
Copy link
Copy Markdown
Member
|
Remove timer references from https://github.com/mscdex/io.js/blob/test-flaky-repl/test/parallel/test-repl.js#L18 and https://github.com/mscdex/io.js/blob/test-flaky-repl/test/parallel/test-repl.js#L48. Other than that LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM is CI is happy |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
PR-URL: nodejs#5914 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Mar 31, 2016
PR-URL: #5914 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Mar 31, 2016
PR-URL: #5914 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 9, 2016
PR-URL: #5914 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
this change (including linting)?
Affected core subsystem(s)
Description of change
Fixes a flaky test on ARM due to too short of a timeout. Example failure: https://ci.nodejs.org/job/node-test-binary-arm/1494/RUN_SUBSET=3,nodes=pi1-raspbian-wheezy/console
CI: https://ci.nodejs.org/job/node-test-pull-request/2075/
Stress test: https://ci.nodejs.org/job/node-stress-single-test/572/