FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gyp: add missing `openssl_fips%` to common.gypi by indutny · Pull Request #5919 · nodejs/node · GitHub

/ node Public

gyp: add missing openssl_fips% to common.gypi - #5919

Closed
indutny wants to merge 1 commit into
nodejs:masterfrom
indutny:feature/atom-3
ConversationCommits (1)ChecksFiles changed
Closed

gyp: add missing openssl_fips% to common.gypi#5919
indutny wants to merge 1 commit into
nodejs:masterfrom
indutny:feature/atom-3

Conversation

indutny commented Mar 27, 2016

Copy link
Copy Markdown
Member

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

gyp

Description of change

No comments, it just should be there in some rare cases.

See: atom/node@cba512d

gyp: add missing openssl_fips% to common.gypi
e0d508c 
No comments, it just should be there in some rare cases.

See: atom/node@cba512d

indutny commented Mar 27, 2016

Copy link
Copy Markdown
Member Author

cc @zcbenz

indutny commented Mar 27, 2016

Copy link
Copy Markdown
Member Author

cc @nodejs/collaborators

indutny added the build Issues and PRs related to build files or the CI. label Mar 27, 2016

jbergstroem commented Mar 27, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/2706/

mscdex commented Mar 27, 2016

Copy link
Copy Markdown
Contributor

Perhaps the commit description should target the build subsystem instead of gyp?

jbergstroem commented Mar 27, 2016

Copy link
Copy Markdown
Member

LGTM. Agree with @mscdex, plus perhaps remove the 'no comment' reference since you link to an example of the problem.

zcbenz commented Mar 27, 2016

Copy link
Copy Markdown
Contributor

Looks good to me, thanks!

indutny commented Mar 27, 2016

Copy link
Copy Markdown
Member Author

Landed in 26a4a4b, thank you everyone!

indutny closed this Mar 27, 2016
indutny deleted the feature/atom-3 branch March 27, 2016 15:35
indutny added a commit that referenced this pull request Mar 27, 2016
build: add missing openssl_fips% to common.gypi
26a4a4b 
See: atom/node@cba512d

PR-URL: #5919
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
evanlucas pushed a commit that referenced this pull request Mar 30, 2016
build: add missing openssl_fips% to common.gypi
f56d6ad 
See: atom/node@cba512d

PR-URL: #5919
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>

MylesBorins commented Mar 30, 2016

Copy link
Copy Markdown
Contributor

@indutny should this be backported to lts?

indutny commented Mar 30, 2016

Copy link
Copy Markdown
Member Author

I would say go for it! 😉

evanlucas mentioned this pull request Mar 31, 2016
Closed
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
build: add missing openssl_fips% to common.gypi
5ee5fa2 
See: atom/node@cba512d

PR-URL: #5919
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
build: add missing openssl_fips% to common.gypi
9a8f922 
See: atom/node@cba512d

PR-URL: #5919
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins mentioned this pull request Apr 11, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL