src: use simdjson - #59308
Conversation
Sorry, something went wrong.
Codecov Report❌ Patch coverage is 79.74684% with 16 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #59308 +/- ##
==========================================
- Coverage 90.00% 89.97% -0.03%
==========================================
Files 649 649
Lines 192180 192192 +12
Branches 37659 37684 +25
==========================================
- Hits 172970 172933 -37
+ Misses 11830 11829 -1
- Partials 7380 7430 +50
... and 32 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
| json_content_.size()); | ||
|
|
||
| simdjson::ondemand::document document; | ||
| simdjson::error_code error = parser_.iterate(json_view).get(document); |
There was a problem hiding this comment.
Actually reading this I realized that if we are moving towards simdjson, it's better to just use simdjson directly in the callsite instead of shimming JSONParser over it, because simdjson does not really support random access, unlike the current JSON parser interface. As a result trying to shim it is bound to lead to repetitive parsing like what's happening here. The correct way to handle fields of unknown order is to just iterate over the fields and handle them for different specific key values on an ad-hoc basis, as suggested by the simdjson documentation: https://github.com/simdjson/simdjson/blob/master/doc/basics.md#using-the-parsed-json
For example, for SEA, this would be the recommended way to parse the document according to the simdjson documentaiton: #59323
Sorry, something went wrong.
Fixes: #59288