FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http: add agent.keepAliveTimeoutBuffer option by wlgh1553 · Pull Request #59352 · nodejs/node · GitHub

/ node Public

http: add agent.keepAliveTimeoutBuffer option - #59352

Closed
wlgh1553 wants to merge 1 commit into
nodejs:mainfrom
wlgh1553:http-keep-alive-timeout-buffer
Closed

http: add agent.keepAliveTimeoutBuffer option#59352
wlgh1553 wants to merge 1 commit into
nodejs:mainfrom
wlgh1553:http-keep-alive-timeout-buffer

Conversation

wlgh1553 commented Aug 4, 2025

Copy link
Copy Markdown
Contributor

Implements the TODO comment for making the keep-alive timeout buffer configurable.

What changed

  • Removed hardcoded HTTP_AGENT_KEEP_ALIVE_TIMEOUT_BUFFER = 1000
  • Added configurable keepAliveTimeoutBuffer option to Agent with validation
  • Added tests
  • Added documentation

Motivation

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

nodejs-github-bot added http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run. labels Aug 4, 2025

wlgh1553 commented Aug 5, 2025

Copy link
Copy Markdown
Contributor Author

This issue was cleared by this PR: #59315

wlgh1553 closed this Aug 5, 2025
wlgh1553 deleted the http-keep-alive-timeout-buffer branch August 5, 2025 05:17
wlgh1553 restored the http-keep-alive-timeout-buffer branch August 13, 2025 10:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

http Issues or PRs related to the http subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL