FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mitigate flaky test-https-agent by Trott · Pull Request #5939 · nodejs/node · GitHub

/ node Public

test: mitigate flaky test-https-agent - #5939

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-https-agent
ConversationCommits (1)ChecksFiles changed
Closed

test: mitigate flaky test-https-agent#5939
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-https-agent

Conversation

Trott commented Mar 28, 2016

Copy link
Copy Markdown
Member

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

test

Description of change

Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

Fixes: #5938
Refs: #5184

test: mitigate flaky test-https-agent
7f9df39 
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

Fixes: nodejs#5938
Refs: nodejs#5184
Trott added https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests. arm Issues and PRs related to the ARM architecture. labels Mar 28, 2016

Trott commented Mar 28, 2016

Copy link
Copy Markdown
Member Author

Stress test that will hopefully show that the current test is flaky on master:
https://ci.nodejs.org/job/node-stress-single-test/573/nodes=pi2-raspbian-wheezy/console

Stress test that will hopefully show that this version of the test is not flaky:
https://ci.nodejs.org/job/node-stress-single-test/574/nodes=pi2-raspbian-wheezy/console

Trott commented Mar 28, 2016

Copy link
Copy Markdown
Member Author

Looks like the stress tests showed what they were supposed to show. Let's move on to general CI:

https://ci.nodejs.org/job/node-test-commit/2718/

Trott commented Mar 29, 2016

Copy link
Copy Markdown
Member Author

CI is green. Review away!

cjihrig commented Mar 29, 2016

Copy link
Copy Markdown
Contributor

Review away!

Ha. Not much to say here. CI is green, so LGTM.

Fishrock123 commented Mar 29, 2016

Copy link
Copy Markdown
Contributor

lgtm

Trott added a commit to Trott/io.js that referenced this pull request Mar 30, 2016
test: mitigate flaky test-https-agent
ea47cc4 
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

PR-URL: nodejs#5939
Fixes: nodejs#5938
Refs: nodejs#5184
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Trott commented Mar 30, 2016

Copy link
Copy Markdown
Member Author

Landed in ea47cc4

Trott closed this Mar 30, 2016
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
test: mitigate flaky test-https-agent
bf94b5a 
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

PR-URL: #5939
Fixes: #5938
Refs: #5184
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
evanlucas mentioned this pull request Mar 31, 2016
Closed
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
test: mitigate flaky test-https-agent
6113f6a 
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

PR-URL: #5939
Fixes: #5938
Refs: #5184
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
test: mitigate flaky test-https-agent
cc1aab9 
Reduce number of clients from 100 to 16 as Raspberry Pi in CI starts to
exhibit flakiness around 22 or so clients.

PR-URL: #5939
Fixes: #5938
Refs: #5184
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins mentioned this pull request Apr 11, 2016
Merged
Trott deleted the fix-https-agent branch January 13, 2022 22:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

arm Issues and PRs related to the ARM architecture. https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL