FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

assert: resolve TODO and rename function by aduh95 · Pull Request #59451 · nodejs/node · GitHub

/ node Public

assert: resolve TODO and rename function - #59451

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:rename-assert
Aug 14, 2025
ConversationCommits (1)ChecksFiles changed
Merged

assert: resolve TODO and rename function#59451
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:rename-assert

Conversation

aduh95 commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Two small changes that should be rather safe, but it's probably a better idea not to backport to avoid breaking anyone (not sure if it qualifies as semver-major):

  • remove self-ref assert.ok.ok.ok…, I doubt anyone is using it.
  • require('node:assert').name is now assert instead of ok – for the sake of having clearer stack traces.

nodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. labels Aug 12, 2025
aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 12, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 12, 2025

nodejs-github-bot commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68578/

codecov Bot commented Aug 12, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.87%. Comparing base (eed1d33) to head (4cc820b).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #59451      +/-   ##
==========================================
- Coverage   89.89%   89.87%   -0.02%     
==========================================
  Files         656      656              
  Lines      192947   192953       +6     
  Branches    37834    37846      +12     
==========================================
- Hits       173443   173419      -24     
- Misses      12054    12086      +32     
+ Partials     7450     7448       -2
Files with missing lines Coverage Δ
lib/assert.js 98.13% <100.00%> (-0.01%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68587/

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 12, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2025
nodejs-github-bot merged commit 91f035e into nodejs:main Aug 14, 2025
85 of 86 checks passed

nodejs-github-bot commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

Landed in 91f035e

aduh95 deleted the rename-assert branch August 14, 2025 13:16
RafaelGSS mentioned this pull request Oct 9, 2025
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
UlisesGascon UlisesGascon approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL