| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
|
I am not a fan of this addition, but I am interested to see what the other team members say. Other bindings and engines are just listed on https://github.com/nodejs/abi-stable-node/blob/doc/node-api-engine-bindings.md for reference. I feel like adding this to our Node-API documentation would possibly give users the impression that we support / back the binding, or favor one binding over the other (as there are multiple Rust bindings). What if the implementation changes for this napi-rs binding? Even if this scenario is unlikely, we'd need to ensure that now that this documentation stays up-to-date. This adds a dependency for us to maintain / monitor in our documentation. A quick web search for "node-api rust" would provide people with the required information to find Rust bindings, alleviating us from needing to include it in official Node.js documentation. |
Sorry, something went wrong.
There was a problem hiding this comment.
commit message should be: doc: ...
Sorry, something went wrong.
I used napi-rs many times, and it's quite ergonomic for developing Rust for Node.js.
Right now, there are only two binding libraries, I think? napi-rsand neon-rs, or just use webassembly from built-in rust feature. And napi-rs is the best of them, I believe.
It's the same situation for TypeScript support in Node.js, right? It uses swc, which is our downstream. Anyway, I +1 on this change, but yeah, we might need basic test cases for this? |
Sorry, something went wrong.
|
I would second @KevinEady opinion. |
Sorry, something went wrong.
There was a problem hiding this comment.
I think the API doc should be impartial on community packages. We should link to https://github.com/nodejs/abi-stable-node/blob/doc/node-api-engine-bindings.md instead.
Sorry, something went wrong.
Fair enough, I'll close this since you've created a PR to link the community package links |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
NAPI-RS has been widely used, hope it can be mentioned in the official documentation
Blocked by nodejs/remark-preset-lint-node#633