FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v20.x backport]deps: V8: cherry-pick 6b1b9bca2a8 by Xiao-Tao · Pull Request #59662 · nodejs/node · GitHub

/ node Public

[v20.x backport]deps: V8: cherry-pick 6b1b9bca2a8 - #59662

Closed
Xiao-Tao wants to merge 1 commit into
nodejs:v20.x-stagingfrom
Xiao-Tao:v20.x-cpu-prof-fix
ConversationCommits (1)ChecksFiles changed
Closed

[v20.x backport]deps: V8: cherry-pick 6b1b9bca2a8#59662
Xiao-Tao wants to merge 1 commit into
nodejs:v20.x-stagingfrom
Xiao-Tao:v20.x-cpu-prof-fix

Conversation

Xiao-Tao commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

Backports #59283 to v20.x.

Fix node-20.19.0 cpu-prof test failures can be seen in Debian CI:
https://buildd.debian.org/status/fetch.php?pkg=nodejs&arch=loong64&ver=20.19.0%2Bdfsg-2&stamp=1743722073&raw=0

CC: @marco-ippolito @aduh95

deps: V8: cherry-pick 6b1b9bca2a8
c1f2f0d 
Origin commit message:

    [loong64][codegen] Avoid memory access under stack pointer

    According to LoongArch ABI doc chapter 8.2:
      "Procedures must not assume the persistence on-stack data of which
       the addresses lie below the stack pointer."

    Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
    Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
    Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#101634}

Refs: v8/v8@6b1b9bc

nodejs-github-bot commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v20.x v8 engine Issues and PRs related to the V8 dependency. labels Aug 28, 2025
marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2025

nodejs-github-bot commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68952/

nodejs-github-bot commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6719/

nodejs-github-bot commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6719/

nodejs-github-bot commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6719/

nodejs-github-bot commented Aug 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68958/

nodejs-github-bot commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68979/

Xiao-Tao commented Sep 1, 2025

Copy link
Copy Markdown
Contributor Author

https://ci.nodejs.org/job/node-test-commit-osx/66558/nodes=osx13-arm64/console
The osx13-arm64 Build timed out .
Can you help restart the CI process? Thanks!

nodejs-github-bot commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68982/

nodejs-github-bot commented Sep 1, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68987/

nodejs-github-bot commented Sep 2, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/68992/

marco-ippolito commented Sep 2, 2025

Copy link
Copy Markdown
Member

The only test failing is unrelated to this PR, I'll backport it

marco-ippolito pushed a commit that referenced this pull request Sep 2, 2025
deps: V8: cherry-pick 6b1b9bca2a8
42224ac 
Origin commit message:

    [loong64][codegen] Avoid memory access under stack pointer

    According to LoongArch ABI doc chapter 8.2:
      "Procedures must not assume the persistence on-stack data of which
       the addresses lie below the stack pointer."

    Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
    Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
    Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#101634}

Backport-PR-URL: #59662
Refs: v8/v8@6b1b9bc
PR-URL: #59283
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

marco-ippolito commented Sep 2, 2025

Copy link
Copy Markdown
Member

Landed in 42224ac

marco-ippolito reopened this Sep 2, 2025

marco-ippolito commented Sep 2, 2025

Copy link
Copy Markdown
Member

It actually needs to wait to land v24 first, so we gotta wait for the next release :(

Xiao-Tao commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

Due to the changes to v8_embedder_string in common.gypi, there may be conflicts when cherry-picking from the main branch to v24.x.
Should I backport this PR to the v24.x-staging branch? @marco-ippolito

marco-ippolito commented Sep 3, 2025

Copy link
Copy Markdown
Member

No we just have that the commits get released in a v24 to make sure it does not break ecosystem then we can backport it to an lts release

Xiao-Tao commented Sep 3, 2025

Copy link
Copy Markdown
Contributor Author

Thank you for your reply, I'll keep an eye on the progress.

Xiao-Tao commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

This fix has been incorporated into the v24.8.0 release (#59816) @marco-ippolito

marco-ippolito pushed a commit that referenced this pull request Nov 19, 2025
deps: V8: cherry-pick 6b1b9bca2a8
acec799 
Origin commit message:

    [loong64][codegen] Avoid memory access under stack pointer

    According to LoongArch ABI doc chapter 8.2:
      "Procedures must not assume the persistence on-stack data of which
       the addresses lie below the stack pointer."

    Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
    Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
    Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#101634}

Backport-PR-URL: #59662
Refs: v8/v8@6b1b9bc
PR-URL: #59283
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

marco-ippolito commented Nov 19, 2025

Copy link
Copy Markdown
Member

Landed in acec799

richardlau mentioned this pull request Nov 19, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL