FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v22.x backport]deps: V8: cherry-pick 6b1b9bca2a8 by Xiao-Tao · Pull Request #59663 · nodejs/node · GitHub

/ node Public

[v22.x backport]deps: V8: cherry-pick 6b1b9bca2a8 - #59663

Closed
Xiao-Tao wants to merge 1 commit into
nodejs:v22.x-stagingfrom
Xiao-Tao:v22.x-fix-cpu-prof
Closed

[v22.x backport]deps: V8: cherry-pick 6b1b9bca2a8#59663
Xiao-Tao wants to merge 1 commit into
nodejs:v22.x-stagingfrom
Xiao-Tao:v22.x-fix-cpu-prof

Conversation

Copy link
Copy Markdown
Contributor

Backports #59283 to v22.x.

CC: @marco-ippolito @aduh95

Origin commit message:

    [loong64][codegen] Avoid memory access under stack pointer

    According to LoongArch ABI doc chapter 8.2:
      "Procedures must not assume the persistence on-stack data of which
       the addresses lie below the stack pointer."

    Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
    Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
    Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#101634}

Refs: v8/v8@6b1b9bc

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. v8 engine Issues and PRs related to the V8 dependency. labels Aug 28, 2025
marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2025

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2025

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

richardlau pushed a commit that referenced this pull request Sep 19, 2025
Origin commit message:

    [loong64][codegen] Avoid memory access under stack pointer

    According to LoongArch ABI doc chapter 8.2:
      "Procedures must not assume the persistence on-stack data of which
       the addresses lie below the stack pointer."

    Change-Id: I92735e052227495ac9884c4290b57eaffbf905e1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6786372
    Auto-Submit: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Reviewed-by: Matthias Liedtke <mliedtke@chromium.org>
    Commit-Queue: Matthias Liedtke <mliedtke@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#101634}

Refs: v8/v8@6b1b9bc
Backport-PR-URL: #59663
PR-URL: #59283
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

Copy link
Copy Markdown
Member

Landed in 2986eca

richardlau closed this Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL