FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix offending max-len linter error by thefourtheye · Pull Request #5980 · nodejs/node · GitHub

/ node Public

test: fix offending max-len linter error - #5980

Closed
thefourtheye wants to merge 1 commit into
nodejs:masterfrom
thefourtheye:fix-lint-stdin
ConversationCommits (1)ChecksFiles changed
Closed

test: fix offending max-len linter error#5980
thefourtheye wants to merge 1 commit into
nodejs:masterfrom
thefourtheye:fix-lint-stdin

Conversation

thefourtheye commented Mar 31, 2016

Copy link
Copy Markdown
Contributor

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?

Affected core subsystem(s)

test

Description of change

fix offending max-len linter error

thefourtheye added the test Issues and PRs related to the tests. label Mar 31, 2016
thefourtheye mentioned this pull request Mar 31, 2016
Merged
2 tasks

Fishrock123 commented Mar 31, 2016

Copy link
Copy Markdown
Contributor

lgtm

Fishrock123 commented Mar 31, 2016

Copy link
Copy Markdown
Contributor

Refs: #5935

test: fix offending max-len linter error
d024316 
Refer: nodejs#5935
PR-URL: nodejs#5980
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

thefourtheye commented Mar 31, 2016

Copy link
Copy Markdown
Contributor Author

CI Run: https://ci.nodejs.org/job/node-test-pull-request/2114/

phillipj commented Mar 31, 2016

Copy link
Copy Markdown
Member

LGTM

thefourtheye commented Mar 31, 2016

Copy link
Copy Markdown
Contributor Author

Linter passes https://ci.nodejs.org/job/node-test-linter/1875/. Landing this, as this is a trivial change and much necessary one for all the builds.

thefourtheye commented Mar 31, 2016

Copy link
Copy Markdown
Contributor Author

Landed in 854f758

thefourtheye added a commit that referenced this pull request Mar 31, 2016
test: fix offending max-len linter error
854f758 
Refer: #5935
PR-URL: #5980
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Phillip Johnsen <johphi@gmail.com>
thefourtheye deleted the fix-lint-stdin branch March 31, 2016 21:19
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
test: fix offending max-len linter error
4f1fa2a 
Refer: #5935
PR-URL: #5980
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Phillip Johnsen <johphi@gmail.com>
This was referenced Apr 5, 2016
Closed
Merged
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
test: fix offending max-len linter error
10fe79b 
Refer: #5935
PR-URL: #5980
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Phillip Johnsen <johphi@gmail.com>
MylesBorins mentioned this pull request Apr 11, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL