@svozza ... can you rebase your branch to the current v4.x-staging to clear out the extraneous commits here?

Oh this is weird, I ddn't see all those extra commits. I'm not actually sure how this happened. I didn't have the v4.x-staging branch before I did this change. All I did was this:

git checkout -b v4.x-staging upstream/v4.x-staging
git cherry-pick 4f6ad5c
git push -u origin v4.x-staging

My branch said it was only 1 commit ahead when I made the PR and when I do git rebase upstream/v4.x-staging it tells me I'm up to date.

OK. I think I've fixed it.

@svozza when you cherry picked did you have conflicts? It appears to me like you merged all of the latest changes as opposed to manually handling the conflicts, as such we have a bunch of documentation in here about ALPN which is not a feature in v4.x

I would suggest you might find it easier in the sections with conflicts to opt for the version present in v4, not in your commit and simply reaudit those sections to make sure they are correct

Done.

@svozza I'm still seeing quite a bit of information in here of v5 specific documentation. Would you be open to redoing this fix from scratch using the v4 doc? Sorry for being tight on this, but I really don't want to accidentally merge incorrect docs

Yeah, no problem. I think I made a mess of the rebase.

@svozza thanks for all the hard work!

@svozza let me know if I can help with anything

Really sorry about the delay, will be able to get to it tonight though!

So I just blew away the branch and started over. No rebasing or any messing around and I think it worked out much better.

I apologize, I was commenting on a backport after the original commit was already accepted. I've removed my nits and will instead address these in a future PR

Oh right, I was in the process of fixing them! :) I agree that 'This event is emitted...` reads better btw.

@whitlockjc the review is appreciated. This backport ended up having to be a complete rewrite due to the differences (to a certain extent).

Well, if I wasn't out of line, let me add them back. Thanks for stepping in @thealphanerd and @svozza for being so willing to help. <3.

Think I got them all!

I'll take another peek. I also see a number of places where we're using a trailing . for option/argument descriptions that themselves are not full sentences. These have been there for some time and for consistency, using what was there makes sense. But if you wanted to clean those up, I wouldn't mind. (I might be in the wrong on that one so I'll state my opinion and let someone else decide.)

@svozza Thanks for addressing the NOTE: and event inconsistencies. The inconsistencies with the trailing periods for argument/option documentation is rampant but this did not start with you.

If no one else has an opinion on the argument/option documentation inconsistencies, LGTM.

Yeah, I really wasn't sure what to do there so I left it originally. I was leaning towards putting fullstops everywhere but thought it might be best not to go down that rabbithole.

Let's see what @thealphanerd has to say. Others welcome of course as well but he was last involved before myself. Great job regardless.

If something is consistent in the docs and not specific to this change I think it should come in another update

@thealphanerd That's what I was thinking. Seems you've assigned to yourself so I'll step out and let you merge when it's ready. Thanks for stepping in.

cool.. can I get an official LGTM from you @whitlockjc

ping @whitlockjc

ping @whitlockjc

I'm going to close for now, please feel free to reopen