test-runner: fix suite timeout - #59853
Merged
nodejs-github-bot merged 1 commit intoOct 9, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
MoLow
force-pushed
the
fix-suite-timeout
branch
from
d457e85 to
a7cf951
Compare
September 11, 2025 11:37
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #59853 +/- ##
==========================================
- Coverage 88.55% 88.53% -0.02%
==========================================
Files 704 704
Lines 208089 208091 +2
Branches 40017 40018 +1
==========================================
- Hits 184270 184233 -37
- Misses 15818 15865 +47
+ Partials 8001 7993 -8
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
MoLow
force-pushed
the
fix-suite-timeout
branch
from
a7cf951 to
16cc3a2
Compare
September 11, 2025 12:45
atlowChemi
approved these changes
Sep 11, 2025
BridgeAR
reviewed
Sep 12, 2025
BridgeAR
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Seems like there are related test failures :)
Sorry, something went wrong.
MoLow
force-pushed
the
fix-suite-timeout
branch
2 times, most recently
from
04fe203 to
99f6289
Compare
October 8, 2025 09:04
MoLow
force-pushed
the
fix-suite-timeout
branch
from
99f6289 to
a405bba
Compare
October 8, 2025 10:27
Copy link
Copy Markdown
Contributor
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - test_runner: fix suite timeout ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/18343105598 |
Sorry, something went wrong.
atlowChemi
approved these changes
Oct 8, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
9 tasks
aduh95
pushed a commit
that referenced
this pull request
Oct 31, 2025
PR-URL: #59853 Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95
pushed a commit
that referenced
this pull request
Nov 7, 2025
PR-URL: #59853 Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced at #57672 where suite timeout option never takes effect