FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v22.x] Update to OpenSSL 3.5 by richardlau · Pull Request #59859 · nodejs/node · GitHub

/ node Public

[v22.x] Update to OpenSSL 3.5 - #59859

Closed
richardlau wants to merge 5 commits into
nodejs:v22.x-stagingfrom
richardlau:v22.x-openssl3.5
Closed

[v22.x] Update to OpenSSL 3.5#59859
richardlau wants to merge 5 commits into
nodejs:v22.x-stagingfrom
richardlau:v22.x-openssl3.5

Conversation

richardlau commented Sep 11, 2025
edited
Loading

Copy link
Copy Markdown
Member

This is an explicit backport to v22.x-staging of the OpenSSL 3.5 PRs:

These all cherry-pick cleanly, but they are explicitly backported here for visibility.

Updating OpenSSL in Node.js 22.x is necessary for us to continue to support Node.js 22.x through to the planned End-of-Life date of 30 April 2027 as OpenSSL 3.0 goes out of support in September 2026.

The first commit is new and addresses concerns in #59715 by fixing the default security level to 1 to minimize disruption when updating to a newer version of Node.js 22 containing the OpenSSL 3.5 updates.

cc @nodejs/crypto @nodejs/releasers

richardlau and others added 5 commits September 11, 2025 16:35
Node.js 22 was released with OpenSSL 3.0 which had a default security
level of 1. OpenSSL 3.2 bumped this to 2, but we need to fix this at
1 to minimize disruption to users of Node.js 22.x.
PR-URL: nodejs#59234
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: nodejs#59234
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: nodejs#59371
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: nodejs#59371
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
richardlau added openssl Issues and PRs related to the OpenSSL dependency. dont-land-on-v20.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Sep 11, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Sep 11, 2025

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Member

@richardlau can we also backport it to v20?

This comment was marked as outdated.

panva added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Sep 11, 2025

This comment was marked as outdated.

richardlau commented Sep 11, 2025
edited
Loading

Copy link
Copy Markdown
Member Author

@richardlau can we also backport it to v20?

I wasn't planning to as Node.js 20 will go End-of-Life before OpenSSL 3.0 does.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Copy Markdown
Collaborator

richardlau added a commit that referenced this pull request Sep 16, 2025
Node.js 22 was released with OpenSSL 3.0 which had a default security
level of 1. OpenSSL 3.2 bumped this to 2, but we need to fix this at
1 to minimize disruption to users of Node.js 22.x.

PR-URL: #59859
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
richardlau pushed a commit that referenced this pull request Sep 16, 2025
PR-URL: #59234
Backport-PR-URL: #59859
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau pushed a commit that referenced this pull request Sep 16, 2025
PR-URL: #59234
Backport-PR-URL: #59859
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
richardlau pushed a commit that referenced this pull request Sep 16, 2025
PR-URL: #59371
Backport-PR-URL: #59859
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
richardlau pushed a commit that referenced this pull request Sep 16, 2025
PR-URL: #59371
Backport-PR-URL: #59859
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Copy link
Copy Markdown
Member Author

Landed in b8870c4...98e399b

richardlau closed this Sep 16, 2025
richardlau pushed a commit that referenced this pull request Sep 22, 2025
Notable changes:

crypto:
  * update root certificates to NSS 3.114 (Node.js GitHub Bot) #59571
deps:
  * fix OpenSSL security level at 1 (Richard Lau) #59859
  * upgrade openssl sources to openssl-3.5.2 (Node.js GitHub Bot) #59371
doc:
  * stabilize --disable-sigusr1 (Rafael Gonzaga) #59707
  * mark `path.matchesGlob` as stable (Aviv Keller) #59572
http:
  * (SEMVER-MINOR) add Agent.agentKeepAliveTimeoutBuffer option (Haram Jeong) #59315
http2:
  * (SEMVER-MINOR) add support for raw header arrays in h2Stream.respond() (Tim Perry) #59455
inspector:
  * add http2 tracking support (Darshan Sen) #59611
sea:
  * (SEMVER-MINOR) implement execArgvExtension (Joyee Cheung) #59560
  * (SEMVER-MINOR) support execArgv in sea config (Joyee Cheung) #59314
stream:
  * (SEMVER-MINOR) add brotli support to CompressionStream and DecompressionStream (Matthew Aitken) #59464
test_runner:
  * (SEMVER-MINOR) support object property mocking (Idan Goshen) #58438
worker:
  * (SEMVER-MINOR) add cpu profile APIs for worker (theanarkh) #59428

PR-URL: #59973
richardlau pushed a commit that referenced this pull request Sep 24, 2025
Notable changes:

crypto:
  * update root certificates to NSS 3.114 (Node.js GitHub Bot) #59571
deps:
  * fix OpenSSL security level at 1 (Richard Lau) #59859
  * upgrade openssl sources to openssl-3.5.2 (Node.js GitHub Bot) #59371
doc:
  * stabilize --disable-sigusr1 (Rafael Gonzaga) #59707
  * mark `path.matchesGlob` as stable (Aviv Keller) #59572
http:
  * (SEMVER-MINOR) add Agent.agentKeepAliveTimeoutBuffer option (Haram Jeong) #59315
http2:
  * (SEMVER-MINOR) add support for raw header arrays in h2Stream.respond() (Tim Perry) #59455
inspector:
  * add http2 tracking support (Darshan Sen) #59611
sea:
  * (SEMVER-MINOR) implement execArgvExtension (Joyee Cheung) #59560
  * (SEMVER-MINOR) support execArgv in sea config (Joyee Cheung) #59314
stream:
  * (SEMVER-MINOR) add brotli support to CompressionStream and DecompressionStream (Matthew Aitken) #59464
test_runner:
  * (SEMVER-MINOR) support object property mocking (Idan Goshen) #58438
worker:
  * (SEMVER-MINOR) add cpu profile APIs for worker (theanarkh) #59428

PR-URL: #59973
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL