module: fix directory option in the enableCompileCache() API - #59931
Merged
nodejs-github-bot merged 3 commits intoOct 9, 2025
Merged
module: fix directory option in the enableCompileCache() API#59931nodejs-github-bot merged 3 commits into
nodejs-github-bot merged 3 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
joyeecheung
force-pushed
the
fix-compile-cache-api
branch
from
a2251fa to
8fa6d26
Compare
September 18, 2025 21:49
The option name should be `directory` to be consistent with the returned result. It should also allow environment variable overrides. This also adds documentation for the new options and improves it.
joyeecheung
force-pushed
the
fix-compile-cache-api
branch
from
8fa6d26 to
9fe76e8
Compare
September 18, 2025 21:57
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #59931 +/- ##
==========================================
+ Coverage 88.23% 88.48% +0.24%
==========================================
Files 703 703
Lines 207393 207550 +157
Branches 39888 40013 +125
==========================================
+ Hits 183003 183645 +642
+ Misses 16346 15900 -446
+ Partials 8044 8005 -39
... and 79 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Aditi-1400
reviewed
Sep 22, 2025
Comment thread
lib/internal/modules/helpers.js
Outdated
Aditi-1400
approved these changes
Sep 22, 2025
Aditi-1400
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Co-authored-by: Aditi <62544124+Aditi-1400@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jsumners-nr
approved these changes
Sep 24, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Aditi-1400
approved these changes
Oct 9, 2025
9 tasks
aduh95
pushed a commit
that referenced
this pull request
Oct 31, 2025
The option name should be `directory` to be consistent with the returned result. It should also allow environment variable overrides. This also adds documentation for the new options and improves it. PR-URL: #59931 Reviewed-By: Aditi Singh <aditisingh1400@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 18, 2025
The option name should be `directory` to be consistent with the returned result. It should also allow environment variable overrides. This also adds documentation for the new options and improves it. PR-URL: #59931 Reviewed-By: Aditi Singh <aditisingh1400@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option name should be directory to be consistent with the returned result. It should also allow environment variable overrides.
This also adds documentation for the new options and improves it.