doc: remove fast fallback information from v8 fast api contribution guidelines - #59951
Closed
gurgunday wants to merge 1 commit into
Closed
doc: remove fast fallback information from v8 fast api contribution guidelines#59951gurgunday wants to merge 1 commit into
gurgunday wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Renegade334
reviewed
Sep 20, 2025
Comment thread
doc/contributing/adding-v8-fast-api.md
Comment on lines
+14
to
+15
| * Throwing errors is not available from within a fast API call. If you need to | ||
| throw, perform validation in JavaScript or only expose a slow API. |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
This isn't actually accurate either – it's possible to throw errors within fast API calls, as the API now provides access to the isolate.
I did try to include this under some wider proposed changes at #58999, although that never garnered much comment. If this PR does go through separately, then this wording will need updating.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Yeah let's do your PR @Renegade334
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reading the Fast API guidelines, seeing the fallback section made me have an incorrect understanding of the API, because fallback no longer exists in FastApiCallbackOptions.
I believe this functionality was removed, so this PR updates the guidelines accordingly.