http: improve writeEarlyHints by avoiding for-of loop - #59958
Merged
nodejs-github-bot merged 1 commit intoOct 6, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
haramj
force-pushed
the
haramjeong-patch-250921
branch
from
0760cdf to
17e98e7
Compare
September 21, 2025 06:10
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #59958 +/- ##
=======================================
Coverage 88.42% 88.43%
=======================================
Files 703 703
Lines 207399 207401 +2
Branches 39986 39992 +6
=======================================
+ Hits 183397 183410 +13
- Misses 15989 15990 +1
+ Partials 8013 8001 -12
... and 46 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
daeyeon
approved these changes
Sep 27, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
gurgunday
approved these changes
Sep 27, 2025
gurgunday
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
aduh95
approved these changes
Sep 28, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
It looks like the CI run for this PR failed due to a flaky test. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #59958 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Oct 22, 2025
PR-URL: #59958 Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is based on the "Unsafe array iteration" principle from the Node.js core development guidelines. for-of loops rely on the Symbol.iterator property, which can be modified by userland code, potentially leading to unpredictable or insecure behavior. Using a standard for loop directly accesses the array elements by index, ensuring a more stable and secure execution flow.
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/primordials.md#unsafe-array-iteration