[v22.x] esm: add experimental support for addon modules - #59961
Closed
legendecas wants to merge 1 commit into
Closed
[v22.x] esm: add experimental support for addon modules#59961legendecas wants to merge 1 commit into
legendecas wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This has a linter failure: Running JS linter... /home/runner/work/node/node/test/addons/esm/test-esm.mjs 7:1 error Unused eslint-disable directive (no problems were reported from 'node-core/require-common-first') ✖ 1 problem (1 error, 0 warnings) 1 error and 0 warnings potentially fixable with the `--fix` option. make: *** [Makefile:1441: lint-js] Error 1 |
Sorry, something went wrong.
PR-URL: nodejs#55844 Fixes: nodejs#40541 Fixes: nodejs#55821 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
legendecas
force-pushed
the
backport-55844-to-22
branch
from
e8ce281 to
ad649aa
Compare
September 21, 2025 19:19
richardlau
approved these changes
Sep 21, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
richardlau
pushed a commit
that referenced
this pull request
Sep 22, 2025
PR-URL: #55844 Backport-PR-URL: #59961 Fixes: #40541 Fixes: #55821 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #55844
Fixes: #40541
Fixes: #55821
Reviewed-By: Guy Bedford guybedford@gmail.com
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Jacob Smith jacob@frende.me
Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com