FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v22.x] vm: expose import attributes on SourceTextModule.moduleRequests by legendecas · Pull Request #59962 · nodejs/node · GitHub

/ node Public

[v22.x] vm: expose import attributes on SourceTextModule.moduleRequests - #59962

Closed
legendecas wants to merge 1 commit into
nodejs:v22.x-stagingfrom
legendecas:backport-58829-to-22
ConversationCommits (1)ChecksFiles changed
Closed

[v22.x] vm: expose import attributes on SourceTextModule.moduleRequests#59962
legendecas wants to merge 1 commit into
nodejs:v22.x-stagingfrom
legendecas:backport-58829-to-22

Conversation

legendecas commented Sep 21, 2025

Copy link
Copy Markdown
Member

Expose import attributes on vm.SourceTextModule.moduleRequests. This deprecates vm.SourceTextModule.dependencySpecifiers as it does not expose import attributes.

PR-URL: #58829
Refs: #37648
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com

vm: expose import attributes on SourceTextModule.moduleRequests
fe1bf02 
PR-URL: nodejs#58829
Refs: nodejs#37648
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

nodejs-github-bot commented Sep 21, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/vm
  • @nodejs/web-infra

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. vm Issues and PRs related to the vm subsystem. labels Sep 21, 2025
legendecas mentioned this pull request Sep 21, 2025
Merged
legendecas changed the title vm: expose import attributes on SourceTextModule.moduleRequests [v22.x] vm: expose import attributes on SourceTextModule.moduleRequests Sep 21, 2025

richardlau commented Sep 21, 2025

Copy link
Copy Markdown
Member

This deprecates vm.SourceTextModule.dependencySpecifiers as it does not expose import attributes.

Shouldn't that have been added to doc/api/deprecations.md on main?

legendecas commented Sep 21, 2025

Copy link
Copy Markdown
Member Author

This deprecates vm.SourceTextModule.dependencySpecifiers as it does not expose import attributes.

Shouldn't that have been added to doc/api/deprecations.md on main?

It is not required to go through deprecation cycle for an experimental API. To fully remove dependencySpecifiers, we will need vm.SourceTextModule.moduleRequests available on all LTS lines first (this PR backports it).

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2025

nodejs-github-bot commented Sep 21, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69313/

richardlau pushed a commit that referenced this pull request Sep 22, 2025
vm: expose import attributes on SourceTextModule.moduleRequests
9807ffd 
PR-URL: #58829
Backport-PR-URL: #59962
Refs: #37648
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>

richardlau commented Sep 22, 2025

Copy link
Copy Markdown
Member

Landed in 9807ffd

richardlau closed this Sep 22, 2025
legendecas deleted the backport-58829-to-22 branch September 23, 2025 09:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL