FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: use dependabot cooldown and move tools/doc by RafaelGSS · Pull Request #59978 · nodejs/node · GitHub

/ node Public

tools: use dependabot cooldown and move tools/doc - #59978

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
RafaelGSS:add-cooldown-dependabot
Sep 30, 2025
ConversationCommits (3)ChecksFiles changed
Merged

tools: use dependabot cooldown and move tools/doc#59978
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
RafaelGSS:add-cooldown-dependabot

Conversation

RafaelGSS commented Sep 22, 2025

Copy link
Copy Markdown
Member

Refs: #59911

cc: @nodejs/security-wg

nodejs-github-bot commented Sep 22, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/security-wg

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Sep 22, 2025
aduh95 reviewed Sep 23, 2025
View reviewed changes
Comment thread .github/dependabot.yml Outdated
Comment on lines +10 to +12
- semver-major: 5
- semver-minor: 5
- semver-patch: 5

aduh95 Sep 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looking at the docs, those are not listed as actual options. I think you meant that:

Suggested change
- semver-major: 5
- semver-minor: 5
- semver-patch: 5
- default-days: 5

Comment thread .github/dependabot.yml Outdated
Comment on lines +23 to +25
- semver-major: 5
- semver-minor: 5
- semver-patch: 5

aduh95 Sep 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
- semver-major: 5
- semver-minor: 5
- semver-patch: 5
- default-days: 5

Comment thread .github/dependabot.yml Outdated
Comment on lines +40 to +42
- semver-major: 5
- semver-minor: 5
- semver-patch: 5

aduh95 Sep 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
- semver-major: 5
- semver-minor: 5
- semver-patch: 5
- default-days: 5

Comment thread .github/dependabot.yml Outdated
Comment on lines +57 to +59
- semver-major: 5
- semver-minor: 5
- semver-patch: 5

aduh95 Sep 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
- semver-major: 5
- semver-minor: 5
- semver-patch: 5
- default-days: 5

RafaelGSS commented Sep 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

They are listed - I forgot to include the -days, but they are there:

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/optimizing-pr-creation-version-updates#setting-up-a-cooldown-period-for-dependency-updates

aduh95 reviewed Sep 23, 2025
View reviewed changes
Comment thread .github/dependabot.yml
Comment on lines +10 to +12
- semver-major-days: 5
- semver-minor-days: 5
- semver-patch-days: 5

aduh95 Sep 23, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Why not go with my previous suggestion?

Suggested change
- semver-major-days: 5
- semver-minor-days: 5
- semver-patch-days: 5
- default-days: 5

RafaelGSS Sep 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Just personal preference, I like things more explicit, it makes change clearer and easier.

RafaelGSS added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 29, 2025
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 29, 2025

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/59978
✔  Done loading data for nodejs/node/pull/59978
----------------------------------- PR info ------------------------------------
Title      tools: use dependabot cooldown and move tools/doc (#59978)
Author     Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS)
Branch     RafaelGSS:add-cooldown-dependabot -> nodejs:main
Labels     meta, author ready
Commits    3
 - tools: use dependabot cooldown and move tools/doc
 - fixup! tools: use dependabot cooldown and move tools/doc
 - fixup! fixup! tools: use dependabot cooldown and move tools/doc
Committers 1
 - RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/59978
Refs: https://github.com/nodejs/node/issues/59911
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59978
Refs: https://github.com/nodejs/node/issues/59911
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 22 Sep 2025 22:21:05 GMT
   ✔  Approvals: 1
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/59978#pullrequestreview-3281597871
   ✘  This PR needs to wait 1 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/18109626886

RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 29, 2025
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 29, 2025

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/59978
✔  Done loading data for nodejs/node/pull/59978
----------------------------------- PR info ------------------------------------
Title      tools: use dependabot cooldown and move tools/doc (#59978)
Author     Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS)
Branch     RafaelGSS:add-cooldown-dependabot -> nodejs:main
Labels     meta, author ready
Commits    3
 - tools: use dependabot cooldown and move tools/doc
 - fixup! tools: use dependabot cooldown and move tools/doc
 - fixup! fixup! tools: use dependabot cooldown and move tools/doc
Committers 1
 - RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/59978
Refs: https://github.com/nodejs/node/issues/59911
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59978
Refs: https://github.com/nodejs/node/issues/59911
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 22 Sep 2025 22:21:05 GMT
   ✔  Approvals: 1
   ✔  - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/59978#pullrequestreview-3281597871
   ✘  This PR needs to wait 0 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/18111664340

mcollina approved these changes Sep 30, 2025
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 30, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2025
nodejs-github-bot merged commit 1d49478 into nodejs:main Sep 30, 2025
36 checks passed

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

Landed in 1d49478

targos commented Oct 1, 2025

Copy link
Copy Markdown
Member

Config seems invalid: https://github.com/nodejs/node/runs/51603058583

RafaelGSS commented Oct 1, 2025

Copy link
Copy Markdown
Member Author

Config seems invalid: https://github.com/nodejs/node/runs/51603058583

Will check as soon as I get back to the computer.

RafaelGSS commented Oct 3, 2025

Copy link
Copy Markdown
Member Author

I have pushed a potential fix for it on my local fork, but I'm not sure how to test it. How did you get the runs list @targos?

Ref: RafaelGSS@3d5cf5b

targos commented Oct 4, 2025

Copy link
Copy Markdown
Member

It's in the GitHub checks of the commit on main: 1d49478

targos commented Oct 4, 2025

Copy link
Copy Markdown
Member

targos pushed a commit that referenced this pull request Oct 6, 2025
tools: use dependabot cooldown and move tools/doc
20d10a2 
Refs: #59911
PR-URL: #59978
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
RafaelGSS mentioned this pull request Oct 6, 2025
Merged
github-actions Bot mentioned this pull request Oct 7, 2025
Merged
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
tools: use dependabot cooldown and move tools/doc
9fae03c 
Refs: #59911
PR-URL: #59978
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
github-actions Bot mentioned this pull request Oct 23, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
mcollina mcollina approved these changes
UlisesGascon UlisesGascon approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL