test: replace diagnostics_channel stackframe in output snapshots - #60024
Merged
nodejs-github-bot merged 1 commit intoOct 3, 2025
Merged
test: replace diagnostics_channel stackframe in output snapshots#60024nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
cjihrig
reviewed
Sep 26, 2025
Comment thread
test/common/assertSnapshot.js
Outdated
legendecas
force-pushed
the
source-map-snapshot
branch
from
ab1b947 to
3e2795c
Compare
September 26, 2025 14:03
cjihrig
approved these changes
Sep 26, 2025
legendecas
force-pushed
the
source-map-snapshot
branch
from
3e2795c to
412d7df
Compare
September 26, 2025 14:13
Copy link
Copy Markdown
Member
Author
|
Simplied the merged regex. |
Sorry, something went wrong.
cjihrig
approved these changes
Sep 26, 2025
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #60024 +/- ##
==========================================
- Coverage 88.49% 88.46% -0.03%
==========================================
Files 703 703
Lines 207529 207546 +17
Branches 40011 40015 +4
==========================================
- Hits 183643 183609 -34
- Misses 15885 15938 +53
+ Partials 8001 7999 -2 see 35 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
lpinca
approved these changes
Sep 26, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #60024 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Oct 22, 2025
PR-URL: #60024 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevent changes in lib/diagnostics_channel.js impact test output snapshots.