FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: optimize priority queue by gurgunday · Pull Request #60039 · nodejs/node · GitHub

/ node Public

lib: optimize priority queue - #60039

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
gurgunday:pq-opt
Oct 4, 2025
ConversationCommits (1)ChecksFiles changed
Merged

lib: optimize priority queue#60039
aduh95 merged 1 commit into
nodejs:mainfrom
gurgunday:pq-opt

Conversation

gurgunday commented Sep 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Further improves performance and fixes leftover issues from my last PR

Benchmarks:

main

node % ./node benchmark/run.js --filter priority util

util/priority-queue.js
util/priority-queue.js n=100000: 6,676,867.584962973

branch

node % ./node benchmark/run.js --filter priority util

util/priority-queue.js
util/priority-queue.js n=100000: 6,854,890.535966754

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 27, 2025

codecov Bot commented Sep 27, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.45%. Comparing base (79f1999) to head (f980885).
⚠️ Report is 37 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60039      +/-   ##
==========================================
+ Coverage   88.43%   88.45%   +0.01%     
==========================================
  Files         703      703              
  Lines      207805   207800       -5     
  Branches    40026    40022       -4     
==========================================
+ Hits       183780   183801      +21     
+ Misses      16012    15979      -33     
- Partials     8013     8020       +7
Files with missing lines Coverage Δ
lib/internal/priority_queue.js 100.00% <100.00%> (+0.80%) ⬆️

... and 45 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gurgunday added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Sep 27, 2025

gurgunday commented Sep 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

node/lib/internal/priority_queue.js

Lines 28 to 32 in cff138c

const pos = ++this.#size;
heap[pos] = value;
if (heap.length === pos)
heap.length *= 2;

This was dead code before, the check never worked

Example coverage form another PR: https://app.codecov.io/gh/nodejs/node/pull/60060/blob/lib/internal/priority_queue.js?dropdown=coverage#L32

BridgeAR commented Sep 29, 2025

Copy link
Copy Markdown
Member

Benchmark https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1737/

BridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2025

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69438/

gurgunday added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 29, 2025
gurgunday changed the title lib: priority_queue pre-grow array and avoid holey reads lib: increase coverage in priority_queue Sep 30, 2025
aduh95 reviewed Sep 30, 2025
View reviewed changes
Comment thread lib/internal/priority_queue.js Outdated

gurgunday commented Oct 2, 2025

Copy link
Copy Markdown
Member Author

@aduh95 PTAL, it's actually faster without the manual array resizing in modern node (V8 does it anyway)

So we just removed the dead code and made it packed (assigning to arr[length] keeps it packed)

gurgunday commented Oct 3, 2025

Copy link
Copy Markdown
Member Author

@BridgeAR you can run the priority queue benchmark again by the way

This was faster for me locally

aduh95 commented Oct 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Started a benchmark including the upcoming V8 update: https://github.com/aduh95/node/actions/runs/18221639411

EDIT: seems to be (significantly) faster across the board 🚀

aduh95 commented Oct 3, 2025

Copy link
Copy Markdown
Contributor

Can you update the commit message? I don't think this has anything to do with coverage, instead you can use something like lib: optimize priority queue.

gurgunday changed the title lib: increase coverage in priority_queue @gurgunday lib: optimize priority queue Oct 3, 2025
gurgunday changed the title @gurgunday lib: optimize priority queue lib: optimize priority queue Oct 3, 2025
gurgunday added the performance Issues and PRs related to the performance of Node.js. label Oct 3, 2025

gurgunday commented Oct 4, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

I need a rerun of macOS and an approval

@aduh95

nodejs-github-bot commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69547/

nodejs-github-bot commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69557/

aduh95 merged commit e978a63 into nodejs:main Oct 4, 2025
52 of 53 checks passed

aduh95 commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

Landed in e978a63

gurgunday deleted the pq-opt branch October 4, 2025 20:17
gurgunday mentioned this pull request Oct 5, 2025
Closed
targos pushed a commit that referenced this pull request Oct 6, 2025
lib: optimize priority queue
c495e1f 
PR-URL: #60039
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
github-actions Bot mentioned this pull request Oct 7, 2025
Merged
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
lib: optimize priority queue
56abc4a 
PR-URL: #60039
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
github-actions Bot mentioned this pull request Oct 23, 2025
Merged
claude Bot mentioned this pull request Nov 3, 2025
Merged
1 task
claude Bot mentioned this pull request Nov 11, 2025
Open
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 approved these changes
juanarbol juanarbol approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL