FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: avoid unnecessary string allocations in SPrintF impl by addaleax · Pull Request #60052 · nodejs/node · GitHub

/ node Public

src: avoid unnecessary string allocations in SPrintF impl - #60052

Closed
addaleax wants to merge 2 commits into
nodejs:mainfrom
addaleax:sprintf-string-view-internals
ConversationCommits (2)ChecksFiles changed
Closed

src: avoid unnecessary string allocations in SPrintF impl#60052
addaleax wants to merge 2 commits into
nodejs:mainfrom
addaleax:sprintf-string-view-internals

Conversation

addaleax commented Sep 28, 2025

Copy link
Copy Markdown
Member
src: make ToLower/ToUpper input args more flexible

In particular, this enables passing std::string_view instead.

src: avoid unnecessary string allocations in SPrintF impl

If we can use a std::string_view instead of a std::string, let's
just do that instead.

src: make ToLower/ToUpper input args more flexible
a0c6a1e 
In particular, this enables passing `std::string_view` instead.
src: avoid unnecessary string allocations in SPrintF impl
c9bad79 
If we can use a `std::string_view` instead of a `std::string`, let's
just do that instead.
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Sep 28, 2025
addaleax changed the title Sprintf string view internals src: avoid unnecessary string allocations in SPrintF impl Sep 28, 2025

codecov Bot commented Sep 28, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.46%. Comparing base (c6316f9) to head (c9bad79).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/debug_utils-inl.h 90.00% 1 Missing ⚠️
src/util-inl.h 90.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60052      +/-   ##
==========================================
+ Coverage   88.45%   88.46%   +0.01%     
==========================================
  Files         703      703              
  Lines      207546   207549       +3     
  Branches    40011    40005       -6     
==========================================
+ Hits       183591   183615      +24     
+ Misses      15949    15906      -43     
- Partials     8006     8028      +22
Files with missing lines Coverage Δ
src/debug_utils.h 80.00% <ø> (ø)
src/util.h 90.90% <ø> (ø)
src/debug_utils-inl.h 86.91% <90.00%> (+1.06%) ⬆️
src/util-inl.h 81.19% <90.00%> (-0.52%) ⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

addaleax added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 28, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2025

nodejs-github-bot commented Sep 28, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69424/

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69469/

addaleax added the review wanted PRs that need reviews. label Sep 30, 2025
addaleax added a commit that referenced this pull request Sep 30, 2025
src: make ToLower/ToUpper input args more flexible
76e1820 
In particular, this enables passing `std::string_view` instead.

PR-URL: #60052
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
addaleax added a commit that referenced this pull request Sep 30, 2025
src: avoid unnecessary string allocations in SPrintF impl
4a9a022 
If we can use a `std::string_view` instead of a `std::string`, let's
just do that instead.

PR-URL: #60052
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

addaleax commented Sep 30, 2025

Copy link
Copy Markdown
Member Author

Landed in f304bc2...4a9a022

addaleax closed this Sep 30, 2025
targos pushed a commit that referenced this pull request Oct 6, 2025
src: make ToLower/ToUpper input args more flexible
de65a5c 
In particular, this enables passing `std::string_view` instead.

PR-URL: #60052
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos pushed a commit that referenced this pull request Oct 6, 2025
src: avoid unnecessary string allocations in SPrintF impl
d744324 
If we can use a `std::string_view` instead of a `std::string`, let's
just do that instead.

PR-URL: #60052
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
github-actions Bot mentioned this pull request Oct 7, 2025
Merged
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
src: make ToLower/ToUpper input args more flexible
6e386c0 
In particular, this enables passing `std::string_view` instead.

PR-URL: #60052
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
src: avoid unnecessary string allocations in SPrintF impl
987841a 
If we can use a `std::string_view` instead of a `std::string`, let's
just do that instead.

PR-URL: #60052
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
github-actions Bot mentioned this pull request Oct 23, 2025
Merged
claude Bot mentioned this pull request Nov 11, 2025
Open
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. review wanted PRs that need reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL