src: remove useless dereferencing in THROW_... - #60054
Closed
addaleax wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Our `THROW_...` helpers can handle strings or string views just fine, all this does is add an extra `strlen()` call that can and should be avoided.
addaleax
force-pushed
the
no-throw-dereference
branch
from
c9da352 to
027d4d1
Compare
September 28, 2025 12:47
jasnell
approved these changes
Sep 28, 2025
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #60054 +/- ##
==========================================
+ Coverage 88.45% 88.46% +0.01%
==========================================
Files 703 703
Lines 207546 207543 -3
Branches 40011 40007 -4
==========================================
+ Hits 183591 183612 +21
+ Misses 15949 15932 -17
+ Partials 8006 7999 -7
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
geeksilva97
approved these changes
Sep 28, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
lpinca
approved these changes
Sep 29, 2025
addaleax
added a commit
that referenced
this pull request
Sep 30, 2025
Our `THROW_...` helpers can handle strings or string views just fine, all this does is add an extra `strlen()` call that can and should be avoided. PR-URL: #60054 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
Our `THROW_...` helpers can handle strings or string views just fine, all this does is add an extra `strlen()` call that can and should be avoided. PR-URL: #60054 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our THROW_... helpers can handle strings or string views just fine, all this does is add an extra strlen() call that can and should be avoided.