src: update contextify to use DictionaryTemplate - #60059
Merged
nodejs-github-bot merged 1 commit intoOct 6, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
addaleax
approved these changes
Sep 28, 2025
This comment was marked as outdated.
This comment was marked as resolved.
legendecas
reviewed
Sep 29, 2025
Comment thread
src/node_contextify.cc
Outdated
jasnell
force-pushed
the
jasnell/contextify-dictionarytemplate
branch
from
67a08e7 to
956b245
Compare
October 4, 2025 12:53
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
jasnell
force-pushed
the
jasnell/contextify-dictionarytemplate
branch
from
956b245 to
fa77052
Compare
October 5, 2025 12:47
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
requested changes
Oct 5, 2025
legendecas
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It is not convincing that a 20-line if-condition is more readable than simple early returns. I don't believe this beneficial change has to be bundled with a subjective style change.
Sorry, something went wrong.
jasnell
force-pushed
the
jasnell/contextify-dictionarytemplate
branch
from
fa77052 to
23601da
Compare
October 5, 2025 22:45
jasnell
force-pushed
the
jasnell/contextify-dictionarytemplate
branch
from
23601da to
b53b4ec
Compare
October 5, 2025 22:55
Copy link
Copy Markdown
Member
Author
|
Blocking an otherwise fully correct PR for a purely subjective style change seems more counterproductive, especially when the style change is consistent with lots of other places throughout the codebase, but ok. I switched it back to the multiple separate if statements. |
Sorry, something went wrong.
addaleax
approved these changes
Oct 5, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
approved these changes
Oct 6, 2025
legendecas
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
tniessen
approved these changes
Oct 6, 2025
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #60059 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More use of DictionaryTemplate