FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark sea tests flaky on macOS x64 by richardlau · Pull Request #60068 · nodejs/node · GitHub

/ node Public

test: mark sea tests flaky on macOS x64 - #60068

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:flakysea
Sep 30, 2025
ConversationCommits (1)ChecksFiles changed
Merged

test: mark sea tests flaky on macOS x64#60068
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:flakysea

Conversation

richardlau commented Sep 29, 2025

Copy link
Copy Markdown
Member

Refs: #59553

These tests are occasionally failing in the CI on osx13-x64, but appear to be always failing on macos15-x64 and blocking anything from landing that requires a full CI.

richardlau added test Issues and PRs related to the tests. macos Issues and PRs related to the macOS platform / OSX. single-executable Issues and PRs related to single-executable applications labels Sep 29, 2025
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 29, 2025

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69441/

richardlau added the lts-watch-v22.x PRs that may need to be released in v22.x label Sep 29, 2025
targos approved these changes Sep 29, 2025
View reviewed changes

targos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would also be OK with a SKIP, as they seem to fail 100% of the time.

codecov Bot commented Sep 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.45%. Comparing base (c6316f9) to head (612d83c).
⚠️ Report is 116 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60068      +/-   ##
==========================================
- Coverage   88.45%   88.45%   -0.01%     
==========================================
  Files         703      703              
  Lines      207546   207546              
  Branches    40011    40008       -3     
==========================================
- Hits       183591   183580      -11     
- Misses      15949    15959      +10     
- Partials     8006     8007       +1

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69442/

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69446/

gurgunday approved these changes Sep 29, 2025
View reviewed changes

gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

RafaelGSS added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 29, 2025

nodejs-github-bot commented Sep 29, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69451/

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69453/

BridgeAR approved these changes Sep 30, 2025
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, while I agree with @targos that skipping would be best

BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label Sep 30, 2025

github-actions Bot commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @BridgeAR. Please 👍 to approve.

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69462/

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69463/

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69465/

richardlau commented Sep 30, 2025

Copy link
Copy Markdown
Member Author

I would also be OK with a SKIP, as they seem to fail 100% of the time.

I went for flaky as, while they are failing 100% of the time on macOS 15 x64, they are generally passing on osx13 x64 and I don't think the Python test runner can make the distinction via the .status file. We can revisit if/when we remove osx13 from the CI.

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69471/

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69474/

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2025
nodejs-github-bot merged commit f304bc2 into nodejs:main Sep 30, 2025
89 checks passed

nodejs-github-bot commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

Landed in f304bc2

richardlau deleted the flakysea branch September 30, 2025 21:28
targos pushed a commit that referenced this pull request Oct 6, 2025
test: mark sea tests flaky on macOS x64
1d5cc5e 
PR-URL: #60068
Refs: #59553
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
github-actions Bot mentioned this pull request Oct 7, 2025
Merged
aduh95 pushed a commit that referenced this pull request Oct 11, 2025
test: mark sea tests flaky on macOS x64
7067d79 
PR-URL: #60068
Refs: #59553
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 added backported-to-v22.x PRs backported to the v22.x-staging branch. and removed lts-watch-v22.x PRs that may need to be released in v22.x labels Oct 11, 2025
github-actions Bot mentioned this pull request Oct 12, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Nov 19, 2025
test: mark sea tests flaky on macOS x64
4b4e38f 
PR-URL: #60068
Refs: #59553
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
marco-ippolito mentioned this pull request Nov 19, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
RafaelGSS RafaelGSS approved these changes
gurgunday gurgunday approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. backported-to-v22.x PRs backported to the v22.x-staging branch. fast-track PRs that do not need to wait for 48 hours to land. macos Issues and PRs related to the macOS platform / OSX. needs-ci PRs that need a full CI run. single-executable Issues and PRs related to single-executable applications test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

Back | FazBrowse Home | New Git URL