FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: V8: cherry-pick 87356585659b by joyeecheung · Pull Request #60069 · nodejs/node · GitHub

/ node Public

deps: V8: cherry-pick 87356585659b - #60069

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:backport-memory-tuning
Oct 8, 2025
Merged

deps: V8: cherry-pick 87356585659b#60069
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
joyeecheung:backport-memory-tuning

Conversation

Copy link
Copy Markdown
Member

Original commit message:

[flags] Ignore memory tuning flags when computing hash for code caching

Change-Id: Ia9aa5b1da8d9b1356bea281cde91bca9ea0b4071
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6938261
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Joyee Cheung <joyee@igalia.com>
Cr-Commit-Position: refs/heads/main@{#102443}

Refs: v8/v8@8735658

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Sep 29, 2025
legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 1, 2025

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Original commit message:

    [flags] Ignore memory tuning flags when computing hash for code caching

    Change-Id: Ia9aa5b1da8d9b1356bea281cde91bca9ea0b4071
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6938261
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#102443}

Refs: v8/v8@8735658
joyeecheung force-pushed the backport-memory-tuning branch from afbb6e4 to ad03400 Compare October 8, 2025 13:08
joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2025

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 8, 2025
nodejs-github-bot merged commit 4eb6e6f into nodejs:main Oct 8, 2025
58 checks passed

Copy link
Copy Markdown
Collaborator

Landed in 4eb6e6f

targos pushed a commit that referenced this pull request Nov 18, 2025
Original commit message:

    [flags] Ignore memory tuning flags when computing hash for code caching

    Change-Id: Ia9aa5b1da8d9b1356bea281cde91bca9ea0b4071
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6938261
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#102443}

Refs: v8/v8@8735658
PR-URL: #60069
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL