FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

process: fix wrong asyncContext under unhandled-rejections=strict by islandryu · Pull Request #60103 · nodejs/node · GitHub

/ node Public

process: fix wrong asyncContext under unhandled-rejections=strict - #60103

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
islandryu:60034
Oct 4, 2025
ConversationCommits (1)ChecksFiles changed
Merged

process: fix wrong asyncContext under unhandled-rejections=strict#60103
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
islandryu:60034

Conversation

islandryu commented Oct 2, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes: #60034

When I looked at the crash point in the issue, I found that asyncId was undefined.
https://github.com/nodejs/node/blob/main/src/api/callback.cc#L185

I suspect that the code may have been mistakenly changed in this PR.
https://github.com/nodejs/node/pull/52108/files#diff-04f0a68c4bc76396de863bbe0982c85d70a5b71432bdc26bc503e3ac317c6f82L263

nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Oct 2, 2025

codecov Bot commented Oct 2, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.43%. Comparing base (c6316f9) to head (dcda482).
⚠️ Report is 40 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60103      +/-   ##
==========================================
- Coverage   88.45%   88.43%   -0.03%     
==========================================
  Files         703      703              
  Lines      207546   207794     +248     
  Branches    40011    40018       +7     
==========================================
+ Hits       183591   183766     +175     
- Misses      15949    16008      +59     
- Partials     8006     8020      +14
Files with missing lines Coverage Δ
lib/internal/process/promises.js 100.00% <100.00%> (ø)

... and 72 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

BridgeAR approved these changes Oct 2, 2025
View reviewed changes

BridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Good catch!

addaleax added async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 2, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 2, 2025

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69524/

Flarna added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 4, 2025
nodejs-github-bot merged commit 60f1a5d into nodejs:main Oct 4, 2025
77 checks passed

nodejs-github-bot commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

Landed in 60f1a5d

targos pushed a commit that referenced this pull request Oct 6, 2025
process: fix wrong asyncContext under unhandled-rejections=strict
b3295b8 
Fixes: #60034
PR-URL: #60103
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
github-actions Bot mentioned this pull request Oct 7, 2025
Merged
aduh95 pushed a commit that referenced this pull request Oct 22, 2025
process: fix wrong asyncContext under unhandled-rejections=strict
c2dd6ee 
Fixes: #60034
PR-URL: #60103
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
github-actions Bot mentioned this pull request Oct 23, 2025
Merged

Tyoneb commented Oct 30, 2025

Copy link
Copy Markdown

Thanks a lot for this fix. Would it be possible to apply it in Node 20.x as well?

marco-ippolito mentioned this pull request Nov 19, 2025
Merged
marco-ippolito pushed a commit that referenced this pull request Nov 19, 2025
process: fix wrong asyncContext under unhandled-rejections=strict
144233b 
Fixes: #60034
PR-URL: #60103
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
claude Bot mentioned this pull request Dec 31, 2025
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
Flarna Flarna approved these changes
gurgunday gurgunday approved these changes

Assignees

No one assigned

Labels

async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Async hook stack corruption with --unhandled-rejections=strict

8 participants

Back | FazBrowse Home | New Git URL