FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

lib: create util.log function by mertcanaltin · Pull Request #60116 · nodejs/node · GitHub

/ node Public

lib: create util.log function - #60116

Closed
mertcanaltin wants to merge 2 commits into
nodejs:mainfrom
mertcanaltin:mert/create-util-log
ConversationCommits (2)ChecksFiles changed
Closed

lib: create util.log function#60116
mertcanaltin wants to merge 2 commits into
nodejs:mainfrom
mertcanaltin:mert/create-util-log

Conversation

mertcanaltin commented Oct 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

hello everyone, last week we disscused this issues : #190,#60032, later we think related nodejs/performance this issue, and @RafaelGSS suggestion after I try create new util.log method for memory friendly log

this new log method : async buffering + batch writes provides

nodejs-github-bot commented Oct 3, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/performance

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Oct 3, 2025

codecov Bot commented Oct 4, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.36620% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.44%. Comparing base (69144e9) to head (17755ff).
⚠️ Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/util/log.js 96.39% 4 Missing ⚠️
src/node_util.cc 80.95% 0 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60116      +/-   ##
==========================================
- Coverage   88.45%   88.44%   -0.02%     
==========================================
  Files         703      704       +1     
  Lines      207796   207947     +151     
  Branches    40021    40046      +25     
==========================================
+ Hits       183806   183912     +106     
- Misses      15977    16021      +44     
- Partials     8013     8014       +1
Files with missing lines Coverage Δ
lib/util.js 98.00% <100.00%> (+0.03%) ⬆️
lib/internal/util/log.js 96.39% <96.39%> (ø)
src/node_util.cc 80.40% <80.95%> (+0.03%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

marco-ippolito commented Oct 4, 2025

Copy link
Copy Markdown
Member

util.log is a deprecated api that has been removed.
It might be confusing to call it with the same name.
https://nodejs.org/docs/latest-v18.x/api/util.html#utillogstring

mcollina requested changes Oct 4, 2025
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Good work!

This has three problems:

  1. it can loose messages in certain exit circumstances (the system for adding this is already present, see #53239).
  2. it provides an odd dx where the messages are handled differently between development and production systems.
  3. util.format is faster than before but still problematic

I’m not convinced this is a good addition to Node.js, and we should focus on actually adding the log system #49296.

RafaelGSS commented Oct 4, 2025

Copy link
Copy Markdown
Member

I’m not convinced this is a good addition to Node.js, and we should focus on actually adding the log system #49296.

I agree and that was my suggestion actually 😄

AugustinMauroy suggested changes Oct 4, 2025
View reviewed changes

AugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

util.log has been used so if we introduce as it it's will be a massive breaking change

https://nodejs.org/docs/latest/api/deprecations.html#DEP0059

mertcanaltin commented Oct 4, 2025

Copy link
Copy Markdown
Member Author

I'll close this PR and contribute to #49296 instead. thanks for the reviews!

mertcanaltin mentioned this pull request Oct 5, 2025
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina requested changes
+1 more reviewer
AugustinMauroy AugustinMauroy requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL