FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "test: ensure message event fires in worker message port test" by lpinca · Pull Request #60126 · nodejs/node · GitHub

/ node Public

Revert "test: ensure message event fires in worker message port test" - #60126

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:revert/9790315e
Oct 13, 2025
ConversationCommits (1)ChecksFiles changed
Merged

Revert "test: ensure message event fires in worker message port test"#60126
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
lpinca:revert/9790315e

Conversation

lpinca commented Oct 5, 2025

Copy link
Copy Markdown
Member

This reverts commit 9790315.

Refs: #59952

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 5, 2025

codecov Bot commented Oct 5, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (ed94bc4) to head (d10b98b).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #60126   +/-   ##
=======================================
  Coverage   88.52%   88.53%           
=======================================
  Files         703      703           
  Lines      207825   207825           
  Branches    40011    40007    -4     
=======================================
+ Hits       183982   183989    +7     
+ Misses      15864    15850   -14     
- Partials     7979     7986    +7

see 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lpinca added the review wanted PRs that need reviews. label Oct 10, 2025
aduh95 approved these changes Oct 10, 2025
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For some reason, the GH web diff UI shows port1.on('message', () => { on line 14, but the actual value on main is

node/test/parallel/test-worker-message-port-infinite-message-loop.js

Line 14 in 75a6fff

port1.on('message', common.mustCallAtLeast(() => {

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Oct 10, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2025

nodejs-github-bot commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69660/

nodejs-github-bot commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69668/

nodejs-github-bot commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69673/

lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2025
nodejs-github-bot merged commit 985e2fb into nodejs:main Oct 13, 2025
85 checks passed

nodejs-github-bot commented Oct 13, 2025

Copy link
Copy Markdown
Collaborator

Landed in 985e2fb

lpinca deleted the revert/9790315e branch October 13, 2025 06:59
RafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
aduh95 pushed a commit that referenced this pull request Oct 31, 2025
Revert "test: ensure message event fires in worker message port test"
bc3ed49 
This reverts commit 9790315.

Refs: #59952
PR-URL: #60126
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
github-actions Bot mentioned this pull request Nov 7, 2025
Closed
aduh95 pushed a commit that referenced this pull request Nov 7, 2025
Revert "test: ensure message event fires in worker message port test"
635af55 
This reverts commit 9790315.

Refs: #59952
PR-URL: #60126
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
github-actions Bot mentioned this pull request Nov 7, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. review wanted PRs that need reviews. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL