FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: clarify stdout/stderr arguments to callback by jasnell · Pull Request #6015 · nodejs/node · GitHub

/ node Public

doc: clarify stdout/stderr arguments to callback - #6015

Closed
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:doc-clarify-fs-doc
ConversationCommits (2)ChecksFiles changed
Closed

doc: clarify stdout/stderr arguments to callback#6015
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:doc-clarify-fs-doc

Conversation

jasnell commented Apr 2, 2016

Copy link
Copy Markdown
Member

Pull Request check-list

  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

Affected core subsystem(s)

doc

Description of change

Clarify that the arguments to fs.execFile and fs.exec callback can be Buffer or strings.

Fixes: #3389

jasnell added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Apr 2, 2016

jasnell commented Apr 2, 2016

Copy link
Copy Markdown
Member Author

@nodejs/documentation

thefourtheye commented Apr 2, 2016

Copy link
Copy Markdown
Contributor

LGTM, but the commit log says fs.exec and fs.execFile, they are actually child_process.exec and child_process.execFile.

jasnell commented Apr 2, 2016

Copy link
Copy Markdown
Member Author

heh, sigh... it's late

jasnell force-pushed the doc-clarify-fs-doc branch from a0e0a88 to 746a543 Compare April 2, 2016 06:25

jasnell commented Apr 2, 2016

Copy link
Copy Markdown
Member Author

Fixed

thefourtheye commented Apr 2, 2016

Copy link
Copy Markdown
Contributor

LGTM

cjihrig reviewed Apr 2, 2016
View reviewed changes
Comment thread doc/api/child_process.markdown Outdated

cjihrig Apr 2, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would either link to encoding or just leave off the (see below). These things tend to become wrong when things get moved around.

jasnell added 2 commits April 2, 2016 17:15
doc: clarify stdout/stderr arguments to callback
2997155 
Clarify that the arguments to child_process.execFile
and child_process.exec callback can be Buffer or strings.

Fixes: nodejs#3389
Address nit
8c8910e
jasnell force-pushed the doc-clarify-fs-doc branch from 746a543 to 8c8910e Compare April 3, 2016 00:16

jasnell commented Apr 3, 2016

Copy link
Copy Markdown
Member Author

@cjihrig ... pulled out the (see below). PTAL

cjihrig commented Apr 3, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell added a commit that referenced this pull request Apr 3, 2016
doc: clarify stdout/stderr arguments to callback
6fd26dc 
Clarify that the arguments to child_process.execFile
and child_process.exec callback can be Buffer or strings.

Fixes: #3389
PR-URL: #6015
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell commented Apr 3, 2016

Copy link
Copy Markdown
Member Author

Landed in 6fd26dc

jasnell closed this Apr 3, 2016
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
doc: clarify stdout/stderr arguments to callback
f12c386 
Clarify that the arguments to child_process.execFile
and child_process.exec callback can be Buffer or strings.

Fixes: #3389
PR-URL: #6015
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 5, 2016
Closed
Merged
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
doc: clarify stdout/stderr arguments to callback
56755de 
Clarify that the arguments to child_process.execFile
and child_process.exec callback can be Buffer or strings.

Fixes: #3389
PR-URL: #6015
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Apr 11, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL