doc: use markdown when branch-diff major release - #60179
Merged
nodejs-github-bot merged 2 commits intoOct 11, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
richardlau
reviewed
Oct 9, 2025
Comment thread
doc/contributing/releases.md
Outdated
richardlau
approved these changes
Oct 9, 2025
marco-ippolito
approved these changes
Oct 9, 2025
cjihrig
approved these changes
Oct 10, 2025
aduh95
approved these changes
Oct 10, 2025
aduh95
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
While we're at it, we could remove those extra $ that do not bring much and are annoying when copying the block
Sorry, something went wrong.
Comment thread
doc/contributing/releases.md
| @@ -1420,9 +1420,9 @@ The commits in the generated changelog must then be organized: | |||
| * Separate all SEMVER-MAJOR, SEMVER-MINOR, and SEMVER-PATCH commits into lists | |||
|
|
|||
| ```console | |||
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| ```console | |
| ```bash |
Sorry, something went wrong.
aduh95
reviewed
Oct 10, 2025
Comment thread
doc/contributing/releases.md
Comment on lines
+1423
to
+1425
| $ branch-diff upstream/vN-1.x upstream/vN.x --require-label=semver-major --group --filter-release --markdown # get all majors | ||
| $ branch-diff upstream/vN-1.x upstream/vN.x --require-label=semver-minor --group --filter-release --markdown # get all minors | ||
| $ branch-diff upstream/vN-1.x upstream/vN.x --exclude-label=semver-major,semver-minor --group --filter-release --markdown # get all patches |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| $ branch-diff upstream/vN-1.x upstream/vN.x --require-label=semver-major --group --filter-release --markdown # get all majors | |
| $ branch-diff upstream/vN-1.x upstream/vN.x --require-label=semver-minor --group --filter-release --markdown # get all minors | |
| $ branch-diff upstream/vN-1.x upstream/vN.x --exclude-label=semver-major,semver-minor --group --filter-release --markdown # get all patches | |
| branch-diff upstream/vN-1.x upstream/vN.x --require-label=semver-major --group --filter-release --markdown # get all majors | |
| branch-diff upstream/vN-1.x upstream/vN.x --require-label=semver-minor --group --filter-release --markdown # get all minors | |
| branch-diff upstream/vN-1.x upstream/vN.x --exclude-label=semver-major,semver-minor --group --filter-release --markdown # get all patches |
Sorry, something went wrong.
9 tasks
aduh95
pushed a commit
that referenced
this pull request
Oct 31, 2025
PR-URL: #60179 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 7, 2025
PR-URL: #60179 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Feb 17, 2026
PR-URL: #60179 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled