FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: clarify that __dirname is module local by jasnell · Pull Request #6018 · nodejs/node · GitHub

/ node Public

doc: clarify that __dirname is module local - #6018

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-globals-dirname-clarification
ConversationCommits (1)ChecksFiles changed
Closed

doc: clarify that __dirname is module local#6018
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:doc-globals-dirname-clarification

Conversation

jasnell commented Apr 2, 2016

Copy link
Copy Markdown
Member

Pull Request check-list

  • Is the commit message formatted according to [CONTRIBUTING.md][0]?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

doc

Description of change

Clarify the __dirname is module local.

Fixes: #5525

jasnell added the doc Issues and PRs related to the documentations. label Apr 2, 2016

jasnell commented Apr 2, 2016

Copy link
Copy Markdown
Member Author

@nodejs/documentation

thefourtheye commented Apr 2, 2016

Copy link
Copy Markdown
Contributor

LGTM.

r-52 commented Apr 2, 2016

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment

cjihrig commented Apr 2, 2016

Copy link
Copy Markdown
Contributor

LGTM

jasnell added a commit that referenced this pull request Apr 2, 2016
doc: clarify that __dirname is module local
c06824b 
Fixes: #5525
PR-URL: #6018
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

jasnell commented Apr 2, 2016

Copy link
Copy Markdown
Member Author

Landed in c06824b

jasnell closed this Apr 2, 2016
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
doc: clarify that __dirname is module local
0ae5d02 
Fixes: #5525
PR-URL: #6018
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 5, 2016
Closed
Merged
Closed
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
doc: clarify that __dirname is module local
9679e2d 
Fixes: #5525
PR-URL: #6018
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Apr 11, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL