doc: createSQLTagStore -> createTagStore - #60182
Merged
nodejs-github-bot merged 1 commit intoOct 11, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Yes that is true, it's wrongly documented. Thanks for the fix 🙌 |
Sorry, something went wrong.
cjihrig
approved these changes
Oct 10, 2025
lpinca
approved these changes
Oct 10, 2025
9 tasks
aduh95
pushed a commit
that referenced
this pull request
Oct 31, 2025
PR-URL: #60182 Refs: https://discord.com/channels/425824580918181889/425824580918181891/1425966053242048584 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 7, 2025
PR-URL: #60182 Refs: https://discord.com/channels/425824580918181889/425824580918181891/1425966053242048584 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @0hmX to confirm that this is correct.
#58748 added a new method, createTagStore, but it's improperly documented as createSQLTagStore
Ref: https://discord.com/channels/425824580918181889/425824580918181891/1425966053242048584