FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: use string_view in `WriteReport()` by addaleax · Pull Request #60201 · nodejs/node · GitHub

/ node Public

src: use string_view in WriteReport() - #60201

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
addaleax:node-report-string-conversions
Oct 12, 2025
ConversationCommits (1)ChecksFiles changed
Merged

src: use string_view in WriteReport()#60201
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
addaleax:node-report-string-conversions

Conversation

addaleax commented Oct 10, 2025

Copy link
Copy Markdown
Member

Since 075936b, TriggerNodeReport() takes std::string_view arguments directly.

src: use string_view in WriteReport()
ad00d97 
Since 075936b, `TriggerNodeReport()` takes `std::string_view`
arguments directly.
addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Oct 10, 2025
nodejs-github-bot added needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. labels Oct 10, 2025
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2025

codecov Bot commented Oct 10, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.56%. Comparing base (e105e82) to head (ad00d97).
⚠️ Report is 14 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #60201      +/-   ##
==========================================
+ Coverage   88.53%   88.56%   +0.03%     
==========================================
  Files         704      704              
  Lines      208087   208087              
  Branches    40006    40017      +11     
==========================================
+ Hits       184223   184288      +65     
+ Misses      15869    15815      -54     
+ Partials     7995     7984      -11
Files with missing lines Coverage Δ
src/node_report_module.cc 87.70% <100.00%> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2025

nodejs-github-bot commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69663/

richardlau added commit-queue Add this label to land a pull request using GitHub Actions. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Oct 10, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2025
nodejs-github-bot merged commit 3ac88a7 into nodejs:main Oct 12, 2025
89 checks passed

nodejs-github-bot commented Oct 12, 2025

Copy link
Copy Markdown
Collaborator

Landed in 3ac88a7

RafaelGSS mentioned this pull request Oct 13, 2025
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
anonrig anonrig approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
daeyeon daeyeon approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL