FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

http2: rename variable to additionalPseudoHeaders by tniessen · Pull Request #60208 · nodejs/node · GitHub

/ node Public

http2: rename variable to additionalPseudoHeaders - #60208

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:http2-psuedo
Oct 13, 2025
Merged

http2: rename variable to additionalPseudoHeaders#60208
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
tniessen:http2-psuedo

Conversation

Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Oct 11, 2025
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2025

Copy link
Copy Markdown
Collaborator

codecov Bot commented Oct 11, 2025
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (e105e82) to head (e018a81).
⚠️ Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60208      +/-   ##
==========================================
+ Coverage   88.53%   88.54%   +0.01%     
==========================================
  Files         704      704              
  Lines      208087   208087              
  Branches    40006    40012       +6     
==========================================
+ Hits       184223   184248      +25     
+ Misses      15869    15854      -15     
+ Partials     7995     7985      -10     
Files with missing lines Coverage Δ
lib/internal/http2/util.js 92.69% <100.00%> (ø)

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

daeyeon added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Oct 11, 2025

Copy link
Copy Markdown
Collaborator

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2025
nodejs-github-bot merged commit 5cf3c3e into nodejs:main Oct 13, 2025
73 checks passed

Copy link
Copy Markdown
Collaborator

Landed in 5cf3c3e

aduh95 pushed a commit that referenced this pull request Oct 31, 2025
PR-URL: #60208
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit that referenced this pull request Nov 7, 2025
PR-URL: #60208
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 17, 2026
PR-URL: #60208
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
aduh95 mentioned this pull request Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants


Back | FazBrowse Home | New Git URL