test: mark split test-watch-mode-kill-signal-* tests as flaky - #60440
Closed
joyeecheung wants to merge 1 commit into
Closed
test: mark split test-watch-mode-kill-signal-* tests as flaky#60440joyeecheung wants to merge 1 commit into
joyeecheung wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The test was split to identify which cases were flaky. The reliability report shows that 2 out of the 3 test cases can time out in the CI. Mark the two persistent flakes as flaky again.
lpinca
approved these changes
Oct 27, 2025
Copy link
Copy Markdown
Member
Author
|
After poking at the test I bit I think I may have some idea about the timeout. Tentative fix in #60443 |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Hopefully fixed by #60443 - also, it seems the status file does not support a complex condition like the one used here. Closing for now. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was split to identify which cases were flaky. The reliability report shows that 2 out of the 3 test cases can time out in the CI. Mark the two persistent flakes as flaky again.
Refs: https://github.com/nodejs/reliability/blob/main/reports/2025-10-27.md
Refs: #60391