FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: ensure assertions are reached on more tests by aduh95 · Pull Request #60641 · nodejs/node · GitHub

/ node Public

test: ensure assertions are reached on more tests - #60641

Merged
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
aduh95:must-call-mustCalls-d
Nov 11, 2025
Merged

test: ensure assertions are reached on more tests#60641
nodejs-github-bot merged 4 commits into
nodejs:mainfrom
aduh95:must-call-mustCalls-d

Conversation

aduh95 commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

Another follow-up of #60125.

nodejs-github-bot added addons Issues and PRs related to native addons. async_hooks Issues and PRs related to the async hooks subsystem. loaders Issues and PRs related to ES module loaders module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Nov 8, 2025

codecov Bot commented Nov 8, 2025
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.54%. Comparing base (d137969) to head (ba929ad).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60641      +/-   ##
==========================================
+ Coverage   88.53%   88.54%   +0.01%     
==========================================
  Files         703      703              
  Lines      208077   208077              
  Branches    40083    40080       -3     
==========================================
+ Hits       184214   184251      +37     
+ Misses      15881    15856      -25     
+ Partials     7982     7970      -12     

see 49 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 9, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2025

Copy link
Copy Markdown
Collaborator

legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 11, 2025
nodejs-github-bot merged commit f1f6f3d into nodejs:main Nov 11, 2025
70 checks passed

Copy link
Copy Markdown
Collaborator

Landed in f1f6f3d

github-project-automation Bot moved this from Need Triage to Done in Node-API Team Project Nov 11, 2025
targos pushed a commit that referenced this pull request Nov 27, 2025
PR-URL: #60641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026
PR-URL: #60641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request Jan 19, 2026
PR-URL: #60641
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addons Issues and PRs related to native addons. async_hooks Issues and PRs related to the async hooks subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. loaders Issues and PRs related to ES module loaders module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL