deps: V8: backport 2e4c5cf9b112 - #60654
Merged
nodejs-github-bot merged 1 commit intoNov 11, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Original commit message:
remove ppc and s390 from the host_arch list
We only support ppc64 and s390x.
Same changes is applied to depot_tools:
http://crrev.com/c/7100932
Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103488}
Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
joyeecheung
approved these changes
Nov 9, 2025
richardlau
approved these changes
Nov 9, 2025
Copy link
Copy Markdown
Member
@miladfarca Have we seen this failure before on ppc64le? 14:19:21 === mjsunit/compiler/conditional-chain === 14:19:21 --- stdout --- 14:19:21 test/mjsunit/mjsunit.js:418: Failure: expected <2510010000> found <-1784957296> 14:19:21 14:19:21 Stack: MjsUnitAssertionError 14:19:21 at assertEquals test/mjsunit/mjsunit.js 513:7 14:19:21 at test/mjsunit/compiler/conditional-chain.js 96:5 14:19:21 at test/mjsunit/compiler/conditional-chain.js 123:3 14:19:21 throw new MjsUnitAssertionError( 14:19:21 ^ 14:19:21 MjsUnitAssertionError 14:19:21 at assertEquals test/mjsunit/mjsunit.js 513:7 14:19:21 at test/mjsunit/compiler/conditional-chain.js 96:5 14:19:21 at test/mjsunit/compiler/conditional-chain.js 123:3 14:19:21 Command: out.gn/ppc64.release/d8 --test test/mjsunit/mjsunit.js test/mjsunit/compiler/conditional-chain.js --random-seed=-333550897 --nohard-abort --testing-d8-test-runner 14:19:21 14:19:21 === 14:19:21 === 1 tests failed 14:19:21 === |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@richardlau Yes that's an intermittent failure due to a maglev bug, this fixes it: |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
juanarbol
approved these changes
Nov 9, 2025
cjihrig
approved these changes
Nov 9, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
RafaelGSS
approved these changes
Nov 9, 2025
sxa
approved these changes
Nov 10, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
targos
added a commit
to targos/node
that referenced
this pull request
Nov 12, 2025
Original commit message:
remove ppc and s390 from the host_arch list
We only support ppc64 and s390x.
Same changes is applied to depot_tools:
http://crrev.com/c/7100932
Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103488}
Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: nodejs#60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Nov 13, 2025
Original commit message:
remove ppc and s390 from the host_arch list
We only support ppc64 and s390x.
Same changes is applied to depot_tools:
http://crrev.com/c/7100932
Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103488}
Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Nov 13, 2025
Original commit message:
remove ppc and s390 from the host_arch list
We only support ppc64 and s390x.
Same changes is applied to depot_tools:
http://crrev.com/c/7100932
Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103488}
Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Nov 13, 2025
Original commit message:
remove ppc and s390 from the host_arch list
We only support ppc64 and s390x.
Same changes is applied to depot_tools:
http://crrev.com/c/7100932
Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103488}
Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
targos
added a commit
that referenced
this pull request
Nov 13, 2025
Original commit message:
remove ppc and s390 from the host_arch list
We only support ppc64 and s390x.
Same changes is applied to depot_tools:
http://crrev.com/c/7100932
Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103488}
Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Nov 13, 2025
Original commit message:
remove ppc and s390 from the host_arch list
We only support ppc64 and s390x.
Same changes is applied to depot_tools:
http://crrev.com/c/7100932
Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103488}
Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
richardlau
pushed a commit
that referenced
this pull request
Nov 14, 2025
Original commit message:
remove ppc and s390 from the host_arch list
We only support ppc64 and s390x.
Same changes is applied to depot_tools:
http://crrev.com/c/7100932
Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103488}
Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 18, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | patch | `25.2.0` -> `25.2.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>nodejs/node (node)</summary> ### [`v25.2.1`](https://github.com/nodejs/node/releases/tag/v25.2.1): 2025-11-17, Version 25.2.1 (Current), @​aduh95 [Compare Source](nodejs/node@v25.2.0...v25.2.1) This release reverts the spec-compliant behavior of sometimes throwing on `localStorage` access. We received feedback that this change on an experimental API was too breaking for a semver-minor release, so we decided to push it back for Node.js 26.0.0. ##### Commits - \[[`ff89b7b6c7`](nodejs/node@ff89b7b6c7)] - **crypto**: ensure documented RSA-PSS saltLength default is used (Filip Skokan) [#​60662](nodejs/node#60662) - \[[`5316b580eb`](nodejs/node@5316b580eb)] - **deps**: V8: backport [`2e4c5cf`](nodejs/node@2e4c5cf9b112) (Michaël Zasso) [#​60654](nodejs/node#60654) - \[[`ca878bc90e`](nodejs/node@ca878bc90e)] - **doc,src,lib**: clarify experimental status of Web Storage support (Antoine du Hamel) [#​60708](nodejs/node#60708) - \[[`a4dee613fd`](nodejs/node@a4dee613fd)] - ***Revert*** "**lib**: throw from localStorage getter on missing storage path" (Antoine du Hamel) [#​60750](nodejs/node#60750) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNzMuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE3My4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
marco-ippolito
pushed a commit
that referenced
this pull request
Jan 13, 2026
Original commit message:
remove ppc and s390 from the host_arch list
We only support ppc64 and s390x.
Same changes is applied to depot_tools:
http://crrev.com/c/7100932
Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
Reviewed-by: Thibaud Michaud <thibaudm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#103488}
Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: #60654
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
remove ppc and s390 from the host_arch list We only support ppc64 and s390x. Same changes is applied to depot_tools: http://crrev.com/c/7100932 Change-Id: I1e4b660a1e46d1c609189301e8fd977fb7434748 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7102361 Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@ibm.com> Reviewed-by: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#103488}Refs: v8/v8@2e4c5cf
Fixes: nodejs/build#4184
Co-authored-by: Michaël Zasso targos@protonmail.com