| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
|
Looking at https://docs.github.com/en/actions/reference/runners/github-hosted-runners#standard-github-hosted-runners-for-public-repositories, macos-14 is not x64, the commit message is a bit misleading |
Sorry, something went wrong.
|
@aduh95 I have dropped "x64" from the commit message. |
Sorry, something went wrong.
|
https://github.com/nodejs/node/actions/runs/19281650811/job/55202686611?pr=60679 === release test-cluster-dgram-1 === Path: parallel/test-cluster-dgram-1 Error: Command: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-cluster-dgram-1.js --- TIMEOUT --- === === 1 tests failed === Failed tests: out/Release/node --test-reporter=spec --test-reporter-destination=stdout --test-reporter=./tools/github_reporter/index.js --test-reporter-destination=stdout /Users/runner/work/node/node/test/parallel/test-cluster-dgram-1.js make[1]: *** [test-ci] Error 1 We skipped this test in #60419 but the PR references macOS 15.7+ while the GitHub workflow for Node.js 20 is running on macOS 14.8.1. @nodejs/releasers Do you think we should just cherry-pick the commit from #60419, or would the commit message be too misleading and we do an explicit backport? |
Sorry, something went wrong.
|
I think it's fine to cherry-pick, the commit message is still technically correct: after all the commit does skip a test that fails on macOS 15.7+. |
Sorry, something went wrong.
SGTM. I've cherry-picked the commit to v20.x-staging and rebased this PR to pick it up. |
Sorry, something went wrong.
Refs: actions/runner-images#13046 PR-URL: #60679 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
| Back | FazBrowse Home | New Git URL |
Refs: actions/runner-images#13046
cc @nodejs/releasers
Prompted by https://redirect.github.com/nodejs/node/pull/60676.