FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: V8: cherry-pick highway@989a498fdf3 by richardlau · Pull Request #60682 · nodejs/node · GitHub

/ node Public

deps: V8: cherry-pick highway@989a498fdf3 - #60682

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:backport-highway-fix-gcc15
Nov 13, 2025
Merged

deps: V8: cherry-pick highway@989a498fdf3#60682
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:backport-highway-fix-gcc15

Conversation

Copy link
Copy Markdown
Member

Original commit message:

GCC 15 removed avx10.2-512 target

PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
Fixes: #60566


cc @nodejs/v8-update

This hasn't landed in upstream V8 yet, so the usual @node-core/utils V8 backport tooling can't be used. I've tried to replicate the commit message format. Hopefully V8 will roll the highway dependency forward to pick up the fix so we won't have to float the patch forever.

richardlau added v8 engine Issues and PRs related to the V8 dependency. dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Nov 11, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Nov 11, 2025
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2025

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

richardlau added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 12, 2025

Copy link
Copy Markdown
Member Author

@targos Should I block this and rebase once #60488 lands? I think otherwise the embedder string will end up being incorrect.

richardlau removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 13, 2025

targos commented Nov 13, 2025

Copy link
Copy Markdown
Member

@richardlau thanks, I just landed the V8 update.

Original commit message:

    GCC 15 removed avx10.2-512 target

    PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
richardlau force-pushed the backport-highway-fix-gcc15 branch from a10eaa3 to 5c19834 Compare November 13, 2025 14:29

Copy link
Copy Markdown
Member Author

Rebased and renumbered the embedder string.

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2025

Copy link
Copy Markdown
Collaborator

richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 13, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 13, 2025
nodejs-github-bot merged commit da71ab6 into nodejs:main Nov 13, 2025
64 checks passed

Copy link
Copy Markdown
Collaborator

Landed in da71ab6

richardlau deleted the backport-highway-fix-gcc15 branch November 13, 2025 19:50
targos pushed a commit to targos/node that referenced this pull request Dec 9, 2025
Original commit message:

    GCC 15 removed avx10.2-512 target

    PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
PR-URL: nodejs#60682
Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Dec 22, 2025
Original commit message:

    GCC 15 removed avx10.2-512 target

    PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
PR-URL: nodejs#60682
Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Feb 4, 2026
Original commit message:

    GCC 15 removed avx10.2-512 target

    PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
PR-URL: nodejs#60682
Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Feb 11, 2026
Original commit message:

    GCC 15 removed avx10.2-512 target

    PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
PR-URL: nodejs#60682
Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit that referenced this pull request Mar 18, 2026
Original commit message:

    GCC 15 removed avx10.2-512 target

    PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
PR-URL: #60682
Fixes: #60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 3, 2026
Original commit message:

    GCC 15 removed avx10.2-512 target

    PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
PR-URL: nodejs#60682
Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
joyeecheung pushed a commit to joyeecheung/node that referenced this pull request Apr 3, 2026
Original commit message:

    GCC 15 removed avx10.2-512 target

    PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
PR-URL: nodejs#60682
Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Renegade334 pushed a commit to Renegade334/node that referenced this pull request Apr 11, 2026
Original commit message:

    GCC 15 removed avx10.2-512 target

    PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
PR-URL: nodejs#60682
Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit that referenced this pull request Apr 15, 2026
Original commit message:

    GCC 15 removed avx10.2-512 target

    PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
PR-URL: #60682
Fixes: #60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 17, 2026
Original commit message:

    GCC 15 removed avx10.2-512 target

    PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
PR-URL: nodejs#60682
Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 24, 2026
Original commit message:

    GCC 15 removed avx10.2-512 target

    PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
PR-URL: nodejs#60682
Fixes: nodejs#60566
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

main fails to compile with gcc 15

6 participants


Back | FazBrowse Home | New Git URL