FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: add flag to compile V8 with Temporal support by targos · Pull Request #60693 · nodejs/node · GitHub

/ node Public

build: add flag to compile V8 with Temporal support - #60693

Closed
targos wants to merge 1 commit into
nodejs:mainfrom
targos:v8-temporal-v1
ConversationCommits (1)ChecksFiles changed
Closed

build: add flag to compile V8 with Temporal support#60693
targos wants to merge 1 commit into
nodejs:mainfrom
targos:v8-temporal-v1

Conversation

targos commented Nov 12, 2025

Copy link
Copy Markdown
Member

It won't work until we build temporal_capi, but is a step forward.

Refs: #58730

build: add flag to compile V8 with Temporal support
d82e414 
It won't work until we build `temporal_capi`, but is a step forward.

Refs: nodejs#58730

nodejs-github-bot commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Nov 12, 2025
targos added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Nov 12, 2025
targos mentioned this pull request Nov 12, 2025
Closed
targos added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 12, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2025

nodejs-github-bot commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70153/

nodejs-github-bot commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6852/

nodejs-github-bot commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6852/

nodejs-github-bot commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6852/

aduh95 commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

I'm getting ../../deps/v8/src/objects/js-temporal-objects.h:27:10: fatal error: 'torque-generated/src/objects/js-temporal-objects-tq.inc' file not found, do we need to add an instruction, in v8.gyp maybe?

targos commented Nov 12, 2025

Copy link
Copy Markdown
Member Author

As written in the commit message, this won't work.

targos commented Nov 12, 2025

Copy link
Copy Markdown
Member Author

I don't want to be blocking progress on this work, so I'm trying to include the results of my experiments in small steps so that someone else can build on it (and doesn't have to start from scratch)

aduh95 commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

The commit message makes it sound like the only thing I need to do is to provide a build version of temporal_rs, which is what I've done but I'm getting the error above, so I do think something's missing here. I'm suggesting v8.gyp in case this was somewhat similar to the wasm and icu integration:

node/tools/v8_gypfiles/v8.gyp

Lines 24 to 35 in a201250

'conditions': [
['v8_enable_i18n_support==1', {
'torque_files': [
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "torque_files =.*?v8_enable_i18n_support.*?torque_files \\+= ")',
],
}],
['v8_enable_webassembly==1', {
'torque_files': [
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "torque_files =.*?v8_enable_webassembly.*?torque_files \\+= ")',
],
}],
],

targos commented Nov 12, 2025

Copy link
Copy Markdown
Member Author

There are many things missing, and I intend to do other PRs after this one. I thought it would be easier to get the changes in small steps 😄.
I don't have enough time to argue on this. If someone wants to bring Temporal in Node.js, feel free to look at the commits I made in https://github.com/targos/node/tree/v8-temporal

targos closed this Nov 12, 2025

aduh95 commented Nov 12, 2025

Copy link
Copy Markdown
Contributor

FWIW if I apply the following diff:

diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
index c3ec7e3ee92..71d27300d66 100644
--- a/tools/v8_gypfiles/v8.gyp
+++ b/tools/v8_gypfiles/v8.gyp
@@ -27,6 +27,11 @@
           '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"  "torque_files =.*?v8_enable_i18n_support.*?torque_files \\+= ")',
         ],
       }],
+      ['v8_enable_temporal_support==1', {
+        'torque_files': [
+          '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"  "torque_files =.*?v8_enable_temporal_support.*?torque_files \\+= ")',
+        ],
+      }],
       ['v8_enable_webassembly==1', {
         'torque_files': [
           '<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn"  "torque_files =.*?v8_enable_webassembly.*?torque_files \\+= ")',

I get further, but I'm getting another error: deps/v8/src/objects/js-date-time-format.cc:949:10: error: use of undeclared identifier 'HijriSimulatedMecca'

targos commented Nov 12, 2025

Copy link
Copy Markdown
Member Author

https://github.com/targos/node/tree/v8-temporal contains this change and other similar ones.

legendecas commented Nov 13, 2025

Copy link
Copy Markdown
Member

HijriSimulatedMecca was removed in temporal_rs 0.1.1. We should continue use temporal_rs 0.1.0 in this V8 version.

aduh95 commented Nov 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Chromium is already using v0.1.2, I expect V8 will catch up soon if they haven't already: chromium/chromium@f700ec5

EDIT: indeed, v8/v8@0cbecc1

aduh95 mentioned this pull request Nov 13, 2025
Merged
legendecas mentioned this pull request Nov 13, 2025
Closed
nodejs-github-bot pushed a commit that referenced this pull request Nov 23, 2025
deps: add temporal_rs 0.1.0
4947af9 
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 23, 2025
build: add temporal_capi gyp
342e87f 
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 23, 2025
test: add basic temporal presence check
e8a5a82 
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
nodejs-github-bot pushed a commit that referenced this pull request Nov 23, 2025
build: ignore built-in temporal when building with shared lib
482b191 
Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2025
deps: add temporal_rs 0.1.0
cb8d53b 
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2025
build: add temporal_capi gyp
18cf3e4 
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2025
test: add basic temporal presence check
3db67b7 
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Nov 27, 2025
build: ignore built-in temporal when building with shared lib
7cbb0df 
Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jan 9, 2026
deps: add temporal_rs 0.1.0
08aa832 
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jan 9, 2026
build: add temporal_capi gyp
47f8b73 
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 pushed a commit that referenced this pull request Jan 9, 2026
test: add basic temporal presence check
d40a728 
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95 added a commit that referenced this pull request Jan 9, 2026
build: ignore built-in temporal when building with shared lib
10553d7 
Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026
deps: add temporal_rs 0.1.0
3cc8570 
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026
build: add temporal_capi gyp
bec7fce 
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026
test: add basic temporal presence check
9426ff6 
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026
build: ignore built-in temporal when building with shared lib
af42ca5 
Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #60703
Refs: #58730
Refs: #60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

joyeecheung joyeecheung approved these changes
richardlau richardlau approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL