FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v25.x] lib: do not provide an empty Proxy from localStorage getter by Renegade334 · Pull Request #60776 · nodejs/node · GitHub

/ node Public

[v25.x] lib: do not provide an empty Proxy from localStorage getter - #60776

Closed
Renegade334 wants to merge 1 commit into
nodejs:v25.x-stagingfrom
Renegade334:v25.x-localstorage-no-path
ConversationCommits (1)ChecksFiles changed
Closed

[v25.x] lib: do not provide an empty Proxy from localStorage getter#60776
Renegade334 wants to merge 1 commit into
nodejs:v25.x-stagingfrom
Renegade334:v25.x-localstorage-no-path

Conversation

Renegade334 commented Nov 18, 2025

Copy link
Copy Markdown
Member

Addresses the original regression in a way that is more consistent with the user experience in v24.x where no storage-related CLI arguments are passed. Access now warns and returns undefined in the case where the requisite path is missing.

As things stand, the behaviour will revert to exception-raising in v26.x; any discussion relating to this specifically should go in the associated issue, this PR is just to re-fix the regression for localStorage users in v25.

Refs: #60303

Renegade334 added the notable-change PRs with changes that should be highlighted in changelogs. label Nov 18, 2025

github-actions Bot commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

The notable-change PRs with changes that should be highlighted in changelogs. label has been added by @Renegade334.

Please suggest a text for the release notes if you'd like to include a more detailed summary, then proceed to update the PR description with the text or a link to the notable change suggested text comment. Otherwise, the commit will be placed in the Other Notable Changes section.

nodejs-github-bot added needs-ci PRs that need a full CI run. v25.x labels Nov 18, 2025
Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 18, 2025

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Nov 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70252/

KhafraDev added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 19, 2025
RafaelGSS pushed a commit that referenced this pull request Dec 10, 2025
lib: do not provide an empty Proxy from localStorage getter
c57a40c 
PR-URL: #60776
Refs: #60303
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>

RafaelGSS commented Dec 10, 2025

Copy link
Copy Markdown
Member

Landed in c57a40c

RafaelGSS closed this Dec 10, 2025
Renegade334 deleted the v25.x-localstorage-no-path branch December 10, 2025 14:03
aduh95 pushed a commit that referenced this pull request Jan 9, 2026
lib: do not provide an empty Proxy from localStorage getter
830ee6d 
PR-URL: #60776
Refs: #60303
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>

aduh95 commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

c57a40c was removed from the staging branch, though I cannot reopen this PR (probably because the branch has been deleted).
FWIW, my opinion is that it's not worth touching localStorage in v25.x given the impact of the previous attempt, though I won't block someone trying – as long I'm not the one releasing the change.

Renegade334 commented Jan 12, 2026

Copy link
Copy Markdown
Member Author

@mcollina has submitted the equivalent to this PR against main in #61333. I suggest that we allow that to land on v25.x, providing releasers are amenable – users are still reporting headaches from the v25.0 regression on the associated issue.

mcollina commented Jan 12, 2026

Copy link
Copy Markdown
Member

@Renegade334 it’s not exactly equivalent, it should correctly not mark localStorage as enumerable.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

KhafraDev KhafraDev approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. notable-change PRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL