tools: dump config.gypi as json by legendecas · Pull Request #60794 · nodejs/node · GitHub

This helps js2c processing the node.gypi correctly when a string contains a quote.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (0b6ae6d) to head (52dd9e8).
⚠️ Report is 21 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60794      +/-   ##
==========================================
+ Coverage   88.04%   88.55%   +0.51%     
==========================================
  Files         703      703              
  Lines      208260   208249      -11     
  Branches    40068    40153      +85     
==========================================
+ Hits       183360   184417    +1057     
+ Misses      16840    15838    -1002     
+ Partials     8060     7994      -66

see 100 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

CI: https://ci.nodejs.org/job/node-test-pull-request/70263/

CI: https://ci.nodejs.org/job/node-test-pull-request/70269/

CI: https://ci.nodejs.org/job/node-test-pull-request/70274/

Landed in 7fd3688

This helps js2c processing the node.gypi correctly when a string contains a quote. PR-URL: #60794 Refs: #60703 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs/node#60794

* chore: bump node in DEPS to v24.13.1 * chore: fixup patches refs: * nodejs/node#60425 * nodejs/node#61270 * nodejs/node#61044 * fix: generate_config_gypi needs to generate valid JSON nodejs/node#60794 * doc: align Buffer.concat documentation with behavior nodejs/node#60405 * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 * build: fix extraneous includes --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#60794

* chore: bump node in DEPS to v24.13.1 * chore: fixup patches refs: * nodejs/node#60425 * nodejs/node#61270 * nodejs/node#61044 * fix: generate_config_gypi needs to generate valid JSON nodejs/node#60794 * doc: align Buffer.concat documentation with behavior nodejs/node#60405 * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 * chore: fixup patch indices * build: fix extraneous includes --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

This helps js2c processing the node.gypi correctly when a string contains a quote. PR-URL: #60794 Refs: #60703 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

* chore: bump node in DEPS to v24.13.1 * chore: fixup patches refs: * nodejs/node#60425 * nodejs/node#61270 * nodejs/node#61044 * fix: generate_config_gypi needs to generate valid JSON nodejs/node#60794 * doc: align Buffer.concat documentation with behavior nodejs/node#60405 * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 * build: fix extraneous includes --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

https: //github.com/nodejs/node/pull/60794 (cherry picked from commit a1d06cd) Co-Authored-By: Shelley Vohr <shelley.vohr@gmail.com>

* chore: bump node in DEPS to v22.22.1 * chore: update patches * chore: fixup remove_obsolete_noarraybufferzerofillscope.patch * deps: update simdjson to 4.2.4 nodejs/node#61056 * fix: generate_config_gypi needs to generate valid JSON https: //github.com/nodejs/node/pull/60794 (cherry picked from commit a1d06cd) Co-Authored-By: Shelley Vohr <shelley.vohr@gmail.com> * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 (cherry picked from commit cb4deec) This test fails on boringssl incompatibilities: https://github.com/electron/electron/pull/49744/changes#r2799802487 Co-Authored-By: Shelley Vohr <shelley.vohr@gmail.com> * test: move sea tests into test/sea nodejs/node#60250 (cherry picked from commit 695929b) * src: fix off-thread cert loading in bundled cert mode nodejs/node#60764 The Node.js cli flag --use-bundled-ca is not supported in Electron --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: John Kleinschmidt <kleinschmidtorama@gmail.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com> Co-authored-by: John Kleinschmidt <jkleinsc@electronjs.org>

tools: dump config.gypi as json

52dd9e8

This helps js2c processing the node.gypi correctly when a string contains a quote.

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Nov 20, 2025

richardlau approved these changes Nov 20, 2025

View reviewed changes

legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2025

marco-ippolito approved these changes Nov 21, 2025

View reviewed changes

cjihrig approved these changes Nov 21, 2025

View reviewed changes

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 22, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 22, 2025

nodejs-github-bot merged commit 7fd3688 into nodejs:main Nov 22, 2025
83 checks passed

legendecas deleted the gyp-json branch November 22, 2025 17:35

github-actions Bot mentioned this pull request Jan 16, 2026

2026-01-19, Version 25.4.0 (Current) #61400

Merged

github-actions Bot mentioned this pull request Feb 3, 2026

2026-02-10, Version 24.13.1 'Krypton' (LTS) #61661

Merged

codebytere added a commit to electron/electron that referenced this pull request Feb 11, 2026

fix: generate_config_gypi needs to generate valid JSON

0f1c6db

nodejs/node#60794

codebytere added a commit to electron/electron that referenced this pull request Feb 11, 2026

fix: generate_config_gypi needs to generate valid JSON

77ad213

nodejs/node#60794

codebytere added a commit to electron/electron that referenced this pull request Feb 11, 2026

fix: generate_config_gypi needs to generate valid JSON

c5a2872

nodejs/node#60794

codebytere mentioned this pull request Feb 12, 2026

build: generate_config_gypi.py generates valid JSON #61791

Merged

codebytere added a commit to electron/electron that referenced this pull request Feb 12, 2026

fix: generate_config_gypi needs to generate valid JSON

d1c7435

nodejs/node#60794

codebytere added a commit to electron/electron that referenced this pull request Feb 12, 2026

fix: generate_config_gypi needs to generate valid JSON

a1d06cd

nodejs/node#60794

codebytere added a commit to electron/electron that referenced this pull request Feb 13, 2026

fix: generate_config_gypi needs to generate valid JSON

39bc1b2

nodejs/node#60794

codebytere added a commit to electron/electron that referenced this pull request Feb 13, 2026

fix: generate_config_gypi needs to generate valid JSON

a84beea

nodejs/node#60794

github-actions Bot mentioned this pull request Feb 16, 2026

[Vulnerability] nodejs/node: Code Injection spaceraccoon/vulnerability-spoiler-alert#25

Open

aduh95 mentioned this pull request Feb 22, 2026

V22.22.1 proposal #61947

Merged

jkleinsc added a commit to electron/electron that referenced this pull request Mar 9, 2026

fix: generate_config_gypi needs to generate valid JSON

68f3146

https: //github.com/nodejs/node/pull/60794 (cherry picked from commit a1d06cd) Co-Authored-By: Shelley Vohr <shelley.vohr@gmail.com>

legendecas mentioned this pull request Jul 21, 2026

fix: handle double quotes inside single-quoted GYP strings nodejs/node-gyp#3346

Closed

tools: dump config.gypi as json by legendecas · Pull Request #60794 · nodejs/node · GitHub

Uh oh!

Uh oh!

tools: dump config.gypi as json - #60794

tools: dump config.gypi as json#60794
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:gyp-json

legendecas commented Nov 20, 2025

Uh oh!

codecov Bot commented Nov 20, 2025 •
edited
Loading

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 21, 2025

Uh oh!

nodejs-github-bot commented Nov 21, 2025

Uh oh!

nodejs-github-bot commented Nov 22, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tools: dump config.gypi as json by legendecas · Pull Request #60794 · nodejs/node · GitHub

Uh oh!

Uh oh!

tools: dump config.gypi as json - #60794

tools: dump config.gypi as json#60794nodejs-github-bot merged 1 commit intonodejs:mainnodejs/node:mainfrom legendecas:gyp-jsonlegendecas/node:gyp-jsonCopy head branch name to clipboard

Conversation

legendecas commented Nov 20, 2025

Uh oh!

codecov Bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Nov 21, 2025

Uh oh!

nodejs-github-bot commented Nov 21, 2025

Uh oh!

nodejs-github-bot commented Nov 22, 2025

Uh oh!

Uh oh!

nodejs-github-bot commented Nov 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tools: dump config.gypi as json#60794
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:gyp-json

codecov Bot commented Nov 20, 2025 •
edited
Loading