FazBrowse GitHub Viewer | Trending | | Home

Tools: [Download Repo ZIP] [Original HTTPS Page]

util: fix parseArgs skipping first positional arg with --eval= and --… by azadgupta1 · Pull Request #60814 · nodejs/node · GitHub

util: fix parseArgs skipping first positional arg with --eval= and --… - #60814

Closed

azadgupta1 wants to merge 1 commit into

nodejs:mainfrom

azadgupta1:fix-eval-args

azadgupta1 commented Nov 22, 2025

Copy link Copy Markdown

Contributor

Fix: handle --eval= and --print= correctly in getMainArgs()

Fixes #60808

parseArgs() was skipping the first positional argument when Node was started
with --eval= or --print=. The logic only checked for --eval / --print
and missed the --eval=... / --print=... forms.

This patch adds startsWith('--eval=') and startsWith('--print=') checks so
getMainArgs() returns the correct slice of process.argv.

After this fix, positional arguments are preserved correctly for all eval/print forms.

nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Nov 22, 2025

IlyasShabi reviewed Nov 22, 2025

View reviewed changes

IlyasShabi left a comment •
edited
Loading

Copy link Copy Markdown

Member

Can you add tests please

Renegade334 reviewed Nov 22, 2025

View reviewed changes

Comment thread lib/internal/util/parse_args/parse_args.js Outdated

codecov Bot commented Nov 22, 2025 •
edited
Loading

Copy link Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (7fd3688) to head (dc3236b).
⚠️ Report is 119 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60814      +/-   ##
==========================================
- Coverage   88.56%   88.53%   -0.03%     
==========================================
  Files         703      703              
  Lines      208254   208425     +171     
  Branches    40156    40197      +41     
==========================================
+ Hits       184430   184537     +107     
- Misses      15828    15893      +65     
+ Partials     7996     7995       -1

Files with missing lines	Coverage Δ
lib/internal/util/parse_args/parse_args.js	99.26% <100.00%> (-0.01%)	⬇️

... and 68 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

azadgupta1 force-pushed the fix-eval-args branch 2 times, most recently from bc85468 to 8ed13dc Compare November 23, 2025 06:39

IlyasShabi reviewed Nov 24, 2025

View reviewed changes

Comment thread test/parallel/test-parse-args-eval.js Outdated

IlyasShabi reviewed Nov 24, 2025

View reviewed changes

Comment thread test/parallel/test-parse-args-eval.js Outdated

Renegade334 requested changes Nov 24, 2025

View reviewed changes

Comment thread test/parallel/test-parse-args-eval.js Outdated

Comment thread test/parallel/test-parse-args-eval.js Outdated

azadgupta1 force-pushed the fix-eval-args branch 2 times, most recently from a89d8c5 to 5919b08 Compare November 25, 2025 04:10

Renegade334 reviewed Nov 25, 2025

View reviewed changes

Comment thread test/parallel/test-parse-args.mjs Outdated

azadgupta1 force-pushed the fix-eval-args branch from 5919b08 to edb11e6 Compare November 25, 2025 08:42

Renegade334 approved these changes Nov 25, 2025

View reviewed changes

Renegade334 left a comment

Copy link Copy Markdown

Member

Thanks for this!

Renegade334 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 25, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2025

azadgupta1 commented Nov 25, 2025

Copy link Copy Markdown

Contributor Author

Thanks for the guidance, appreciate it!

Renegade334 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 25, 2025

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Renegade334 requested a review from IlyasShabi December 1, 2025 00:44

IlyasShabi approved these changes Dec 1, 2025

View reviewed changes

aduh95 reviewed Dec 4, 2025

View reviewed changes

Comment thread test/parallel/test-parse-args.mjs Outdated

shadowspawn reviewed Dec 4, 2025

View reviewed changes

Comment thread test/parallel/test-parse-args.mjs

shadowspawn commented Dec 4, 2025

Copy link Copy Markdown

Member

Nice catch and change. I like checking the internal options instead of doing a pseudo parse of execArgv.

azadgupta1 commented Dec 7, 2025

Copy link Copy Markdown

Contributor Author

Just checking in — let me know if anything else is required from me.

Renegade334 commented Dec 7, 2025

Copy link Copy Markdown

Member

There's #60814 (review) regarding the order of the test assertions, otherwise all good 👍

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 9, 2025

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Dec 9, 2025

Copy link Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70459/

Renegade334 pushed a commit to Renegade334/node that referenced this pull request Dec 11, 2025

util: fix parseArgs skipping positional arg with --eval and --print

060deae

PR-URL: nodejs#60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

Renegade334 closed this Dec 11, 2025

Renegade334 commented Dec 11, 2025

Copy link Copy Markdown

Member

Landed in 060deae

This was referenced Dec 11, 2025

util.parseArgs() omits the first positional argument when used with the --eval= option #60808

Closed

test: check util.parseArgs argv parsing with actual process execution #61089

Merged

nodejs-github-bot pushed a commit that referenced this pull request Dec 30, 2025

test: check util.parseArgs argv parsing with actual process execution

7b7f693

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

aduh95 pushed a commit that referenced this pull request Jan 9, 2026

util: fix parseArgs skipping positional arg with --eval and --print

22a2270

PR-URL: #60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

aduh95 pushed a commit that referenced this pull request Jan 9, 2026

test: check util.parseArgs argv parsing with actual process execution

700775d

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

aduh95 pushed a commit that referenced this pull request Jan 12, 2026

util: fix parseArgs skipping positional arg with --eval and --print

1a2d5b7

PR-URL: #60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

aduh95 pushed a commit that referenced this pull request Jan 12, 2026

test: check util.parseArgs argv parsing with actual process execution

b580f7b

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026

util: fix parseArgs skipping positional arg with --eval and --print

98b6dc1

PR-URL: #60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

RafaelGSS pushed a commit that referenced this pull request Jan 13, 2026

test: check util.parseArgs argv parsing with actual process execution

c08afc5

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

github-actions Bot mentioned this pull request Jan 16, 2026

2026-01-19, Version 25.4.0 (Current) #61400

Merged

aduh95 pushed a commit that referenced this pull request Jan 19, 2026

util: fix parseArgs skipping positional arg with --eval and --print

bb6e680

PR-URL: #60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

aduh95 pushed a commit that referenced this pull request Jan 19, 2026

test: check util.parseArgs argv parsing with actual process execution

da4d4d4

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

github-actions Bot mentioned this pull request Feb 3, 2026

2026-02-10, Version 24.13.1 'Krypton' (LTS) #61661

Merged

aduh95 pushed a commit that referenced this pull request Feb 17, 2026

util: fix parseArgs skipping positional arg with --eval and --print

d54ba03

PR-URL: #60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

aduh95 pushed a commit that referenced this pull request Feb 17, 2026

test: check util.parseArgs argv parsing with actual process execution

73b6755

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

aduh95 pushed a commit that referenced this pull request Feb 19, 2026

util: fix parseArgs skipping positional arg with --eval and --print

51f4260

PR-URL: #60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

aduh95 pushed a commit that referenced this pull request Feb 19, 2026

test: check util.parseArgs argv parsing with actual process execution

aefc310

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

aduh95 pushed a commit that referenced this pull request Feb 21, 2026

util: fix parseArgs skipping positional arg with --eval and --print

cadf09f

PR-URL: #60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

aduh95 pushed a commit that referenced this pull request Feb 21, 2026

test: check util.parseArgs argv parsing with actual process execution

e0f7559

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

aduh95 mentioned this pull request Feb 22, 2026

V22.22.1 proposal #61947

Merged

aduh95 pushed a commit that referenced this pull request Feb 23, 2026

util: fix parseArgs skipping positional arg with --eval and --print

78e5fa2

PR-URL: #60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>

aduh95 pushed a commit that referenced this pull request Feb 23, 2026

test: check util.parseArgs argv parsing with actual process execution

1383168

PR-URL: #61089
Refs: #60814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Aviv Keller <me@aviv.sh>

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters

Show hidden characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 left review comments

Renegade334 approved these changes

IlyasShabi approved these changes

+1 more reviewer

shadowspawn left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

Milestone

No milestone

Back | FazBrowse Home | New Git URL