FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: move some test from sequential to parallel by santigimeno · Pull Request #6087 · nodejs/node · GitHub

/ node Public

test: move some test from sequential to parallel - #6087

Closed
santigimeno wants to merge 1 commit into
nodejs:masterfrom
santigimeno:from_seq_to_parallel
ConversationCommits (1)ChecksFiles changed
Closed

test: move some test from sequential to parallel#6087
santigimeno wants to merge 1 commit into
nodejs:masterfrom
santigimeno:from_seq_to_parallel

Conversation

santigimeno commented Apr 6, 2016

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

The only test with modifications is test-stdin-child-proc that was
passing when it should not because the exit code of the child process
was not being checked.

I have run the tests on Debian Jessie 64 and SmartOS and pass on both.

claudiorodriguez added the test Issues and PRs related to the tests. label Apr 6, 2016

claudiorodriguez commented Apr 6, 2016

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/2183/

santigimeno commented Apr 6, 2016

Copy link
Copy Markdown
Member Author

/cc @nodejs/testing

cjihrig commented Apr 7, 2016

Copy link
Copy Markdown
Contributor

LGTM and CI is green.

jbergstroem commented Apr 7, 2016

Copy link
Copy Markdown
Member

@santigimeno: can you run these tests with -J as well?

jbergstroem commented Apr 7, 2016

Copy link
Copy Markdown
Member

Disregard that. make test uses -J. I've spent too much time in CI :)

jbergstroem commented Apr 7, 2016

Copy link
Copy Markdown
Member

LGTM

thefourtheye reviewed Apr 7, 2016
View reviewed changes
Comment thread test/parallel/test-stdin-child-proc.js Outdated

thefourtheye Apr 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The path has to be updated.

jasnell commented Apr 7, 2016

Copy link
Copy Markdown
Member

LGTM with nits addressed

santigimeno force-pushed the from_seq_to_parallel branch from 0d8a8a7 to c085ef1 Compare April 7, 2016 23:35

santigimeno commented Apr 7, 2016

Copy link
Copy Markdown
Member Author

PR updated. Thanks!

test: move some test from sequential to parallel
c085ef1 
The only test with modifications is `test-stdin-child-proc` that was
passing when it should not because the exit code of the child process
was not being checked.

jasnell commented Apr 8, 2016

Copy link
Copy Markdown
Member

New CI after update: https://ci.nodejs.org/job/node-test-pull-request/2221/

thefourtheye commented Apr 8, 2016

Copy link
Copy Markdown
Contributor

LGTM if CI is green.

claudiorodriguez commented Apr 8, 2016

Copy link
Copy Markdown
Contributor

CI green. LGTM

jasnell pushed a commit that referenced this pull request Apr 9, 2016
test: move some test from sequential to parallel
eaab17c 
The only test with modifications is `test-stdin-child-proc` that was
passing when it should not because the exit code of the child process
was not being checked.

PR-URL: #6087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>

jasnell commented Apr 9, 2016

Copy link
Copy Markdown
Member

Landed in eaab17c

jasnell closed this Apr 9, 2016
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
test: move some test from sequential to parallel
089b855 
The only test with modifications is `test-stdin-child-proc` that was
passing when it should not because the exit code of the child process
was not being checked.

PR-URL: #6087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
test: move some test from sequential to parallel
9856b80 
The only test with modifications is `test-stdin-child-proc` that was
passing when it should not because the exit code of the child process
was not being checked.

PR-URL: #6087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
This was referenced Apr 21, 2016
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
test: move some test from sequential to parallel
9293946 
The only test with modifications is `test-stdin-child-proc` that was
passing when it should not because the exit code of the child process
was not being checked.

PR-URL: #6087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
test: move some test from sequential to parallel
720b8f0 
The only test with modifications is `test-stdin-child-proc` that was
passing when it should not because the exit code of the child process
was not being checked.

PR-URL: #6087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins pushed a commit that referenced this pull request May 17, 2016
test: move some test from sequential to parallel
fbaa32f 
The only test with modifications is `test-stdin-child-proc` that was
passing when it should not because the exit code of the child process
was not being checked.

PR-URL: #6087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
test: move some test from sequential to parallel
25d4b5b 
The only test with modifications is `test-stdin-child-proc` that was
passing when it should not because the exit code of the child process
was not being checked.

PR-URL: #6087
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
MylesBorins mentioned this pull request May 18, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL