tools: run tests --without-amaro on test-shared macOS - #60902
Merged
nodejs-github-bot merged 1 commit intoDec 3, 2025
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
targos
previously approved these changes
Nov 30, 2025
aduh95
force-pushed
the
disable-build-options-ci
branch
from
95caad8 to
119dabb
Compare
November 30, 2025 15:28
Copy link
Copy Markdown
Contributor
Author
|
Tests are completely broken on builds without SQLite, fixing it would be out of scope for this PR |
Sorry, something went wrong.
aduh95
force-pushed
the
disable-build-options-ci
branch
from
119dabb to
86fa3cb
Compare
November 30, 2025 21:46
marco-ippolito
approved these changes
Nov 30, 2025
This was referenced Dec 1, 2025
legendecas
approved these changes
Dec 3, 2025
targos
pushed a commit
that referenced
this pull request
Dec 5, 2025
PR-URL: #60902 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95
added a commit
that referenced
this pull request
Jan 9, 2026
PR-URL: #60902 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jan 13, 2026
PR-URL: #60902 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have no CI that run the tests with those options. Rather than introducing an additional job, we can reuse that job which is already kinda redundant anyway (we already test with macOS, and we already test with shared-libs on Linux).
I did not include --without-intl and --without-ssl because we already have Jenkins CI jobs dedicated to those.
EDIT: because each of the options were broken on its own right, I'm splitting this in separate PRs. This one only enables --without-amaro as the fix for its tests has already landed.