FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v24.x backport] repl: move completion logic to internal module by targos · Pull Request #61046 · nodejs/node · GitHub

/ node Public

[v24.x backport] repl: move completion logic to internal module - #61046

Merged
aduh95 merged 1 commit into
nodejs:v24.x-stagingfrom
targos:backport-repl-v24
Feb 3, 2026
ConversationCommits (1)ChecksFiles changed
Merged

[v24.x backport] repl: move completion logic to internal module#61046
aduh95 merged 1 commit into
nodejs:v24.x-stagingfrom
targos:backport-repl-v24

Conversation

targos commented Dec 13, 2025

Copy link
Copy Markdown
Member

Backport of #59889

nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Dec 13, 2025
dario-piotrowicz approved these changes Dec 13, 2025
View reviewed changes

dario-piotrowicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good to me! Thanks @targos! 🫶

targos changed the title [v24.x] repl: move completion logic to internal module [v24.x backport] repl: move completion logic to internal module Dec 14, 2025
avivkeller added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2025

nodejs-github-bot commented Dec 19, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70519/

nodejs-github-bot commented Dec 20, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70542/

avivkeller added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 10, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 10, 2026

nodejs-github-bot commented Jan 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70751/

repl: move completion logic to internal module
e781d88 
PR-URL: nodejs#59889
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos force-pushed the backport-repl-v24 branch from 3961e22 to e781d88 Compare January 23, 2026 13:57

targos commented Jan 23, 2026

Copy link
Copy Markdown
Member Author

Simple rebase without conflicts.

nodejs-github-bot commented Jan 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70996/

nodejs-github-bot commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71090/

aduh95 merged this pull request into nodejs:v24.x-staging Feb 3, 2026
52 checks passed

aduh95 commented Feb 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Landed in 2d6309f

aduh95 pushed a commit that referenced this pull request Feb 3, 2026
repl: move completion logic to internal module
58fc3da 
PR-URL: #59889
Backport-PR-URL: #61046
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos deleted the backport-repl-v24 branch February 3, 2026 19:09
aduh95 pushed a commit that referenced this pull request Feb 4, 2026
repl: move completion logic to internal module
2d6309f 
PR-URL: #59889
Backport-PR-URL: #61046
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request Feb 6, 2026
repl: move completion logic to internal module
f7450a9 
PR-URL: #59889
Backport-PR-URL: #61046
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

avivkeller avivkeller approved these changes
dario-piotrowicz dario-piotrowicz approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL