util: use primordials consistently in comparisons.js - #61198
Merged
aduh95 merged 1 commit intoAug 17, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #61198 +/- ##
==========================================
+ Coverage 88.53% 88.55% +0.01%
==========================================
Files 703 703
Lines 208599 208613 +14
Branches 40229 40243 +14
==========================================
+ Hits 184685 184728 +43
+ Misses 15939 15894 -45
- Partials 7975 7991 +16
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
avivkeller
approved these changes
Dec 29, 2025
Ayoub-Mabrouk
force-pushed
the
util-use-primordials-comparisons
branch
from
9b5d7b1 to
10b4d8d
Compare
December 29, 2025 16:46
Replace native methods with primordials.
Ayoub-Mabrouk
force-pushed
the
util-use-primordials-comparisons
branch
from
10b4d8d to
2413d7a
Compare
December 29, 2025 17:47
VoltrexKeyva
approved these changes
Dec 30, 2025
This comment was marked as outdated.
ljharb
approved these changes
Feb 19, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
The benchmarks can be run with CATEGORY=assert and FILTER=deepequal once the CI is fixed in nodejs/build#4374 |
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
PR-URL: #61198 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jordan Harband <ljharb@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
PR-URL: #61198 Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Jordan Harband <ljharb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace native array.push() with ArrayPrototypePush in lib/internal/util/comparisons.js for consistency and security.
This improves protection against prototype pollution and aligns with the primordials pattern used throughout the codebase.