FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix flaky test-http-client-abort by Trott · Pull Request #6124 · nodejs/node · GitHub

/ node Public

test: fix flaky test-http-client-abort - #6124

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fewer
ConversationCommits (1)ChecksFiles changed
Closed

test: fix flaky test-http-client-abort#6124
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fewer

Conversation

Trott commented Apr 8, 2016

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test http arm

Description of change

Fixes: #6080

Trott added http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. arm Issues and PRs related to the ARM architecture. labels Apr 8, 2016

Trott commented Apr 8, 2016

Copy link
Copy Markdown
Member Author

Stress test showing this version of the test is not flaky on pi2-raspbian-wheezy: https://ci.nodejs.org/job/node-stress-single-test/586/nodes=pi2-raspbian-wheezy/console

Trott mentioned this pull request Apr 8, 2016
Closed

santigimeno commented Apr 8, 2016

Copy link
Copy Markdown
Member

LGTM

1 similar comment

cjihrig commented Apr 8, 2016

Copy link
Copy Markdown
Contributor

LGTM

Trott commented Apr 8, 2016

Copy link
Copy Markdown
Member Author

Stress test showing the version of this test that is on master is flaky:
https://ci.nodejs.org/job/node-stress-single-test/587/nodes=pi2-raspbian-wheezy/console

Trott commented Apr 8, 2016

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/2223/

mscdex commented Apr 8, 2016

Copy link
Copy Markdown
Contributor

Only 999 runs? ;-)

LGTM though

jasnell commented Apr 9, 2016

Copy link
Copy Markdown
Member

LGTM

jasnell pushed a commit that referenced this pull request Apr 9, 2016
test: fix flaky test-http-client-abort
a9aa199 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell commented Apr 9, 2016

Copy link
Copy Markdown
Member

Landed in a9aa199

jasnell closed this Apr 9, 2016
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
test: fix flaky test-http-client-abort
d6f26a3 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
test: fix flaky test-http-client-abort
251fc03 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
test: fix flaky test-http-client-abort
476535c 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
jasnell pushed a commit that referenced this pull request Apr 26, 2016
test: fix flaky test-http-client-abort
7ce9670 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 17, 2016
test: fix flaky test-http-client-abort
eae2f86 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
test: fix flaky test-http-client-abort
a865975 
Fixes: #6080
PR-URL: #6124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request May 18, 2016
Merged
Trott deleted the fewer branch January 13, 2022 22:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

arm Issues and PRs related to the ARM architecture. http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test test-http-client-abort.js

6 participants

Back | FazBrowse Home | New Git URL